Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] add mediatype to setinfo for music #9396

Merged
merged 1 commit into from Apr 3, 2016
Merged

Conversation

@BigNoid
Copy link
Member

BigNoid commented Mar 19, 2016

Enables scripts to set dbtype so context/info will work for listproviders.
This is just a c/p from the video mediatype plus moving m_type from protected to public

@@ -240,6 +240,7 @@ namespace XBMCAddon
* - lyrics : string (On a dark desert highway...)
* - playcount : integer (2) - number of times this item has been played
* - lastplayed : string (%Y-%m-%d %h:%m:%s = 2009-04-05 23:16:04)
* - mediatype : string - "song", "album", "artist"

This comment has been minimized.

Copy link
@phil65

phil65 Mar 19, 2016

Member

according to IsValidMediaType(), "music" is also valid. (I have no idea what it should be used for though)

@BigNoid BigNoid force-pushed the BigNoid:music_mediatype branch 2 times, most recently from d137e43 to 08fae28 Mar 20, 2016
@phil65

This comment has been minimized.

Copy link
Member

phil65 commented Mar 24, 2016

@tamland

@BigNoid perhaps you could also cherrypick Montellese@f5a0fe4 from @Montellese ? (might need some additional changes to ListItem.cpp so we can set it via python)

@DaveTBlake

This comment has been minimized.

Copy link
Member

DaveTBlake commented Mar 25, 2016

For consistency with the rest of CMusicInfoTag I think this should add a SetType method (GetType already exists) rather than make m_type variable public.

@Montellese

This comment has been minimized.

Copy link
Member

Montellese commented Mar 25, 2016

Yes please don't expose members directly. Implement a setter instead.

@BigNoid BigNoid force-pushed the BigNoid:music_mediatype branch from 08fae28 to 858e48e Mar 26, 2016
Enables scripts to set dbtype so context/info will work for listproviders
@BigNoid BigNoid force-pushed the BigNoid:music_mediatype branch from 6bb1d24 to 2e35f87 Mar 26, 2016
@BigNoid

This comment has been minimized.

Copy link
Member Author

BigNoid commented Mar 26, 2016

Updated with SetType method.

@phil65 It would need some work in PictureInfoTag as well I think, I couldn't quite figure out what is needed exactly there in any case, so maybe thats something for another PR.

@phil65

This comment has been minimized.

Copy link
Member

phil65 commented Mar 26, 2016

ok, sure. Thx.

@MartijnKaijser

This comment has been minimized.

Copy link
Member

MartijnKaijser commented Apr 2, 2016

jenkins build this please
Good for merge?

@phil65 phil65 merged commit 95f54c2 into xbmc:master Apr 3, 2016
1 of 2 checks passed
1 of 2 checks passed
default Merged build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BigNoid BigNoid deleted the BigNoid:music_mediatype branch Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.