Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoPlayer: inputstream changes, bump to 1.0.2 #9410

Merged
merged 2 commits into from Mar 21, 2016
Merged

VideoPlayer: inputstream changes, bump to 1.0.2 #9410

merged 2 commits into from Mar 21, 2016

Conversation

FernetMenta
Copy link
Contributor

  • drop check for extension
  • listitemproperty "inputstreamaddon" to request a specific inputstream addon
  • fix pathlist that that compared to itself

@FernetMenta FernetMenta added Type: Fix non-breaking change which fixes an issue Type: Improvement non-breaking change which improves existing functionality v17 Krypton Component: Video labels Mar 20, 2016
@FernetMenta
Copy link
Contributor Author

@mapfau could you have a look please

@ghost
Copy link

ghost commented Mar 20, 2016

Just to be sure: The extension check has been removed?
If so: doesnt make it sense to remove pathlist also? And make listitemproperty "inputstreamaddon" mandatory?

@FernetMenta
Copy link
Contributor Author

The extension check has been removed?

yes

doesnt make it sense to remove pathlist also?

I don't think so.

And make listitemproperty "inputstreamaddon" mandatory?

that would remove the chance to play a .strm file

@ghost
Copy link

ghost commented Mar 20, 2016

Yes, I thougth also about it, but hoped that strm files support listitem vaues to be set.
Shouldn't we make strm file parser more flexible to support listItem?

@FernetMenta
Copy link
Contributor Author

@mapfau see 397b8f2

pushing to a vector changes memory.

@FernetMenta
Copy link
Contributor Author

jenkins build this please

@FernetMenta FernetMenta added this to the Krypton 17.0-alpha1 milestone Mar 21, 2016
FernetMenta added a commit that referenced this pull request Mar 21, 2016
@FernetMenta
Merge pull request #9410 from FernetMenta/inputstream
19c335a 
VideoPlayer: inputstream changes, bump to 1.0.2
@FernetMenta FernetMenta merged commit 19c335a into xbmc:master Mar 21, 2016
@FernetMenta FernetMenta deleted the inputstream branch March 21, 2016 20:48
@ghost
Copy link

ghost commented Mar 21, 2016

pushing to a vector changes memory.
arghhhhh, greenhorn error :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Video Type: Fix non-breaking change which fixes an issue Type: Improvement non-breaking change which improves existing functionality v17 Krypton
Projects
None yet
Milestone
Krypton 17.0-alpha1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FernetMenta