add idShow to the episode table and drop the unneeded tvshowlinkepisode #943

Merged
merged 1 commit into from May 10, 2012

4 participants

@jmarshallnz
Team Kodi member

Mostly cleanup.

A couple of questions about this one though:

  1. I've taken the easy route by appending idShow to the episodes table. This means it can't easily be expanded in the future (using the silly c## stuff). IMO this is not a bad thing - perhaps it will encourage us to redo the db.

  2. Because of this, it's meant I needed to shuffle the order in the episodeview, which meant bring some stuff out of GetCommonDetails. IMO this is nicer than stuffing idShow into one of the c## columns.

@Montellese
Team Kodi member

I totally agree with removing tvshowlinkepisode. Gets rid of some (unnecessary) JOINs which is always nice.

  1. I always disliked the c## stuff (even though I admit that it has a few benefits) so no complaints from me on that one.
  2. GetCommonDetails() was/is pretty neat but idShow is a much better (and easier understandable) field name than c##.

So no objections from my side.

@jmarshallnz
Team Kodi member

Cheers for the review. Mayaswell break everything at once...

@jmarshallnz jmarshallnz was assigned May 10, 2012
@jmarshallnz jmarshallnz merged commit aacfed8 into xbmc:master May 10, 2012
@ScudLee

When exactly does the idShow value get set when scanning in new episodes? Because none of my newly scraped episodes are showing up, and looking in the database all their idShow fields are empty and if I manually add the right value, the episode shows up. All the old episodes are fine from the update, just nothing new.

Same thing on a fresh install. Not looked through all the SQL statements and not an expert by any means but shouldn't "CREATE TABLE episode" gain an ", idShow integer" on L195? Also a little later an index is created on season rather than seasons - L312. Plus whatever is causing the idShow integer to not be set in the episode table. I very quickly and very very blindly tried modifying L1138 to set it but that didn't seem to fix it.

Team Kodi member

The season/seasons thing is already fixed.

Looks like I missed the update for show - will fix.

Team Kodi member

Rest should be fixed now as well.

@tru tru added a commit to plexinc/plex-home-theater-public that referenced this pull request Jan 10, 2014
@tru tru Add Container.Property(PlexPreplay) that is set when we are showing a…
… prepay

Fixes #943
ec136a9
@dalehamel dalehamel added a commit to RasPlex/plex-home-theatre that referenced this pull request Jan 27, 2014
@tru tru Add Container.Property(PlexPreplay) that is set when we are showing a…
… prepay

Fixes #943
5875e85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment