This ensures we remain inside a transaction for the complete run of UpdateVersion. Before there was a (very slim) chance that UpdateOldVersion could be called from thread A while thread B was in between UpdateOldVersion/UpdateVersionNumber.
I doubt this is an actual issue, but it makes sense to complete it all under a transaction so that the rollback occurs as one would expect for the cases where we screw up the UpdateOldVersion for mysql :p
Looks good to me. But since we are relying on the exception now we could even get rid of that return bool value (which now allways returns true). But thats only cosmetic of course.
Correct - I figured at some point we might want to have a check that returns false in the future. Doesn't hurt.
wrap UpdateOldVersion/UpdateVersionNumber in a transaction to ensure …
…both are completed in sync
no need for CommitTransaction in UpdateVersionNumber as it has no ass…
no need for try/catch block in UpdateVersionNumber
no need for begin/commit transaction in the derived UpdateOldVersion()'s
cosmetics: align code