[Peripherals] m_bNeedsPolling broken for busses where it is set outsi…

[mk01]

…de constructor

@Montellese
commit cb9cb00 is introducing this issue for bus types where m_bNeedsPolling is initially set only after initial device scan - based on search results (for instance CEC).

[Montellese]

This might clash with #9510 so pinging @tamland as well.

[tamland]

@Montellese Why did you move TriggerDeviceScan into CPeripherals::Initialise? It effectively undoes cb9cb00

[Montellese]

@tamland: I'm confused what you want to know from me. This PR is not from me but cb9cb00 is. The reason for cb9cb00 was that in some cases we triggered a device scan before the bus was initialised which lead to deadlocks and sometimes even crashes (due to missing locks).

[tamland]

@Montellese I'm asking you because you removed the call to ScanForDevices from CPeripheralBus::Initialise to CPeripherals::Initialise in commit cb9cb00. In this PR, @mk01 is moving that call back to CPeripheralBus::Initialise so I'm wondering if this re-introduce the issue you fixed (I don't really know this code very well)

[mk01]

@Montellese @tamland
I had the same question (if we can reproduce and retest) ...

but in between got another idea - I will push .

@Montellese @tamland
done

[tamland]

included in #9510