Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Peripherals] m_bNeedsPolling broken for busses where it is set outsi… #9538

Closed
wants to merge 1 commit into from

Conversation

@mk01
Copy link
Contributor

commented Apr 3, 2016

…de constructor

@Montellese
commit cb9cb00 is introducing this issue for bus types where m_bNeedsPolling is initially set only after initial device scan - based on search results (for instance CEC).

@Montellese

This comment has been minimized.

Copy link
Member

commented Apr 3, 2016

This might clash with #9510 so pinging @tamland as well.

@tamland

This comment has been minimized.

Copy link
Member

commented Apr 4, 2016

@Montellese Why did you move TriggerDeviceScan into CPeripherals::Initialise? It effectively undoes cb9cb00

@Montellese

This comment has been minimized.

Copy link
Member

commented Apr 4, 2016

@tamland: I'm confused what you want to know from me. This PR is not from me but cb9cb00 is. The reason for cb9cb00 was that in some cases we triggered a device scan before the bus was initialised which lead to deadlocks and sometimes even crashes (due to missing locks).

@tamland

This comment has been minimized.

Copy link
Member

commented Apr 4, 2016

@Montellese I'm asking you because you removed the call to ScanForDevices from CPeripheralBus::Initialise to CPeripherals::Initialise in commit cb9cb00. In this PR, @mk01 is moving that call back to CPeripheralBus::Initialise so I'm wondering if this re-introduce the issue you fixed (I don't really know this code very well)

@mk01

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2016

@Montellese @tamland
I had the same question (if we can reproduce and retest) ...

but in between got another idea - I will push .

@Montellese @tamland
done

@mk01 mk01 force-pushed the mk01:master_needspoll branch from a0f3a6a to 4643a95 Apr 4, 2016

@tamland

This comment has been minimized.

Copy link
Member

commented Apr 23, 2016

included in #9510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.