Skip to content


CURL::IsFullPath() should return true for UNC paths, which seem to work #954

merged 1 commit into from

2 participants


Pretty straightforward. UNC paths can be added to XBMC as sources, and seem to work OK, possibly by coincidence (they drop through to SetFileName() on the complete path in Parse()).

However, IsFullPath() returns false on them currently, which is clearly wrong, breaking things like thumbs which use the IsFullPath() check to see whether it should append the folder/file onto the cached path etc.

@elupus mind having a quick look?

@jmarshallnz jmarshallnz was assigned

Agreed, but I think until we reach that utopia we mayaswell at least not cause issues with those that do manage to force those paths into XBMC (I presume by typing them in directly in the path dialog or XML).

@jmarshallnz jmarshallnz merged commit 533c344 into xbmc:master
@dalehamel dalehamel referenced this pull request from a commit in RasPlex/plex-home-theatre
@tru tru Fix client ip resolve with newer versions of microhttpd
Fixes #954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 10, 2012
  1. CURL::IsFullPath() should return true for UNC paths, which seem to wo…

    Jonathan Marshall committed
    …rk (perhaps by coincidence)
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 0 deletions.
  1. +1 −0  xbmc/URL.cpp
1  xbmc/URL.cpp
@@ -656,6 +656,7 @@ bool CURL::IsFullPath(const CStdString &url)
if (url.size() && url[0] == '/') return true; // /foo/bar.ext
if (url.Find("://") >= 0) return true; // foo://bar.ext
if (url.size() > 1 && url[1] == ':') return true; // c:\\foo\\bar\\bar.ext
+ if (,2,"\\\\") == 0) return true; // \\UNC\path\to\file
return false;
Something went wrong with that request. Please try again.