CURL::IsFullPath() should return true for UNC paths, which seem to work#954

Merged
merged 1 commit into from
+1 −0 

2 participants

Owner

Pretty straightforward. UNC paths can be added to XBMC as sources, and seem to work OK, possibly by coincidence (they drop through to SetFileName() on the complete path in Parse()).

However, IsFullPath() returns false on them currently, which is clearly wrong, breaking things like thumbs which use the IsFullPath() check to see whether it should append the folder/file onto the cached path etc.

@elupus mind having a quick look?

 Jonathan Marshall CURL::IsFullPath() should return true for UNC paths, which seem to wo… …rk (perhaps by coincidence) 937e5f4
Collaborator
was assigned
Owner

Agreed, but I think until we reach that utopia we mayaswell at least not cause issues with those that do manage to force those paths into XBMC (I presume by typing them in directly in the path dialog or XML).

merged commit 533c344 into xbmc:master
referenced this pull request from a commit in RasPlex/plex-home-theatre
 tru Fix client ip resolve with newer versions of microhttpd Fixes #954 9af8406
…rk (perhaps by coincidence)