CURL::IsFullPath() should return true for UNC paths, which seem to work #954

merged 1 commit into from May 10, 2012


None yet

2 participants


Pretty straightforward. UNC paths can be added to XBMC as sources, and seem to work OK, possibly by coincidence (they drop through to SetFileName() on the complete path in Parse()).

However, IsFullPath() returns false on them currently, which is clearly wrong, breaking things like thumbs which use the IsFullPath() check to see whether it should append the folder/file onto the cached path etc.

@elupus mind having a quick look?

Jonathan Marshall CURL::IsFullPath() should return true for UNC paths, which seem to wo…
…rk (perhaps by coincidence)
elupus commented May 10, 2012

Should be fine.. Though I would so like to get rid of these non url paths

@jmarshallnz jmarshallnz was assigned May 10, 2012

Agreed, but I think until we reach that utopia we mayaswell at least not cause issues with those that do manage to force those paths into XBMC (I presume by typing them in directly in the path dialog or XML).

@jmarshallnz jmarshallnz merged commit 533c344 into xbmc:master May 10, 2012
@dalehamel dalehamel pushed a commit to RasPlex/plex-home-theatre that referenced this pull request Jan 7, 2014
@tru tru Fix client ip resolve with newer versions of microhttpd
Fixes #954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment