[AE] added: PulseAE::EnumerateOutputDevices #957

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant
@ghost

ghost commented May 10, 2012

this re-adds the Pulse enumeration code from the old PulseAudioDirectSound.

not tested with passthrough devices around, anyone capable, please do.

@ghost

ghost commented May 11, 2012

@elupus can you test the passthrough for me please (it still only enumerates). i have no easy way to do so..

Member

elupus commented May 11, 2012

Will do.

@elupus elupus commented on the diff May 12, 2012

xbmc/cores/AudioEngine/Engines/PulseAE.cpp
+ if(!pa_format_info_is_pcm(i->formats[idx]))
+ {
+ add = true;
+ break;
+ }
+ }
+#endif
+ }
+ else
+ add = true;
+
+ if (add)
+ {
+ CStdString desc, sink;
+ if (sinkStruct->list->size() == 0)
+ sinkStruct->list->push_back(AEDevice("(PulseAudio)", "pulse:default@default"));
@elupus

elupus May 12, 2012

Member

This looks rather shitty in GUI. It aught to at least be Default (PulseAudio).

@elupus

elupus May 12, 2012

Member

This hack should probably be moved into the EnumerateDevices function instead and insert it at the front.

@elupus

elupus May 12, 2012

Member

g_localizeStrings.Get(409) was previous at least for this.

Member

elupus commented May 12, 2012

With above fixed, merge. It is somewhat useless on my machine thou. It seems pulse audio only lists available sinks in current Config. Normally there is only one config per system card. So even if i have HDMI/SPDIF/Analog separate output, i only get one item in this list. I have to change config in pavucontrol to get the other ones.

Member

elupus commented May 12, 2012

Also, passthrough isn't support in the stream handler. Will try to get that going.

Member

elupus commented May 12, 2012

Okey. so I re-added passthrough support for pulseaudio. I also managed to get this pull to list sinks properly on my HW, but it required a change to my pulseaudio config. It stupidly only lists one sink per profile.

I had to add:

[Profile multisinked]
output-mappings = analog-stereo iec958-stereo hdmi-stereo hdmi-surround hdmi-stereo-extra1 hdmi-surround-extra1 hdmi-stereo-extra2 hdmi-surround-extra2 hdmi-stereo-extra3 hdmi-surround-extra3
input-mappings = analog-stereo
skip-probe = yes

to /usr/share/pulseaudio/alsa-mixer/profile-sets/extra-hdmi.conf

@ghost

ghost commented May 14, 2012

pushed.

ghost closed this May 14, 2012

@dalehamel dalehamel pushed a commit to RasPlex/plex-home-theatre that referenced this pull request Jan 7, 2014

@tru tru API: Fixed location attribute when state is stopped.
Fixes #957
c88fc4f

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment