[python-api] add xbmcgui.Dialog().contextmenu() #9591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil65
force-pushed
the
python_context_menu
branch
from
a67ece4
to
a514c78
Compare
phil65
changed the title
phil65
force-pushed
the
python_context_menu
branch
from
a514c78
to
1606d38
Compare
phil65
added
Type: Improvement
phil65
force-pushed
the
python_context_menu
branch
from
1606d38
to
2128469
Compare
| { | ||
| choices.Add(i, list[i]); | ||
| } | ||
| return pDialog->ShowAndGetChoice(choices); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
phil65
force-pushed
the
python_context_menu
branch
from
2128469
to
1fae6d3
Compare
|
updated. also fixed some more typos in docs. |
|
while testing this, i noticed there's a positioning issue (not related to this PR). if the script xml is coded in 1080, but the script is run in a 720p skin, for example, this is what happens in confluence (when using the script provided xml): |
|
yup, can confirm that. |
|
since that bug is not related to this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When workin with WindowXML objects, creating some sort of contextmenu is quite painful. Both me and @ronie workarounded that in some ways (by either using DialogSelect() or by using a custom script window XML)
This should allow to get rid of these workarounds.
@tamland
EDIT: renamed to contextmenu() which suits better to overall naming.