Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveAE: Fix use of invalidated iterator #9630

Merged
merged 1 commit into from Apr 15, 2016

Conversation

Projects
None yet
2 participants
@fritsch
Copy link
Member

commented Apr 15, 2016

Fixup c0aa16a

@fritsch

This comment has been minimized.

Copy link
Member Author

commented Apr 15, 2016

@fritsch fritsch force-pushed the fritsch:aefixup branch from 3ad5e31 to 754d4ec Apr 15, 2016

@@ -1507,8 +1507,8 @@ void CActiveAE::FlushEngine()

void CActiveAE::ClearDiscardedBuffers()
{
std::list<CActiveAEBufferPool*>::iterator it;
for (it=m_discardBufferPools.begin(); it!=m_discardBufferPools.end(); ++it)
std::list<CActiveAEBufferPool*>::iterator it = m_discardBufferPools.begin();

This comment has been minimized.

Copy link
@FernetMenta

FernetMenta Apr 15, 2016

Member

please use auto here

thanks

ActiveAE: Fix use of invalidated iterator
v2: Use auto instead of typed iterator

@fritsch fritsch force-pushed the fritsch:aefixup branch from 754d4ec to 1726f1c Apr 15, 2016

@FernetMenta FernetMenta merged commit f974026 into xbmc:master Apr 15, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@FernetMenta FernetMenta added this to the Krypton 17.0-alpha1 milestone Apr 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.