Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg: thread specific logging level #9632

Merged
merged 1 commit into from Apr 16, 2016

Conversation

Projects
None yet
2 participants
@FernetMenta
Copy link
Member

commented Apr 16, 2016

this reduces lot of ffmpeg logspam

@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2016

jenkins build this please

1 similar comment
@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2016

jenkins build this please

@FernetMenta FernetMenta merged commit 2c72ac9 into xbmc:master Apr 16, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Merged build finished.
Details

@FernetMenta FernetMenta deleted the FernetMenta:logging branch Apr 16, 2016

@afedchin

This comment has been minimized.

Copy link
Member

commented Apr 18, 2016

@FernetMenta this makes ffmpeg log spamming if debugging log is enabled even if ffmpeg logging is disabled.
perhaps the following code makes more sense

  if ((level > AV_LOG_WARNING &&
     !g_advancedSettings.CanLogComponent(LOGFFMPEG)) ||
     CFFmpegLog::GetLogLevel() < 0)
    return;
@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2016

With you code other threads won't be able to enable any logging beyond WARNING because only VideoPlayer has CFFmpegLog::GetLogLevel() > 0
What ffmpeg logs do you consider spam?

@afedchin

This comment has been minimized.

Copy link
Member

commented Apr 18, 2016

I have a video file which causes a huge amount of ffmpeg messages like the following

Debug Print: ffmpeg[4BA0]: [mov,mp4,m4a,3gp,3g2,mj2] count=1, duration=0
Debug Print: ffmpeg[4BA0]: [mov,mp4,m4a,3gp,3g2,mj2] count=1, duration=5005
Debug Print: ffmpeg[4BA0]: [mov,mp4,m4a,3gp,3g2,mj2] count=1, duration=2002

in that case Kodi is unable to play it bacuse spends all cpu time for logging.

@afedchin

This comment has been minimized.

Copy link
Member

commented Apr 18, 2016

level of this messages is AV_LOG_TRACE

@FernetMenta

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2016

ahh, I see what's wrong now.. I will submit a fix.

@afedchin

This comment has been minimized.

Copy link
Member

commented Apr 18, 2016

thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.