Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] EPG data import performance tuning. #9636

Merged
merged 1 commit into from Apr 19, 2016

Conversation

@ksooo
Copy link
Member

commented Apr 16, 2016

This patch increases the performance of (initial) epg data import by refraining from expensive eager evaluation of the epg tag that might belong to a timer tag.

Of course I double checked that the epg tag will be created later when it is actually needed.

@xhaggi @Jalle19 mind taking a look.

}
else if (!m_bStartAnyTime && !m_bEndAnyTime)
CSingleLock lock(m_critSection);
if (!m_epgTag)

This comment has been minimized.

Copy link
@Jalle19

Jalle19 Apr 17, 2016

Member

This check seems unnecessary, it's already checked earlier.

This comment has been minimized.

Copy link
@ksooo

ksooo Apr 17, 2016

Author Member

Hehe we had that already. This is the double checked locking pattern. First check needs to be done without muted locked. Between first and second check (this time with the lock) the member value might have changed.

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2016

jenkins build this please

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2016

If nobody objects I will merge this PR tomorrow

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2016

AppVeyor seems to be broken, not related to this PR.

@ksooo ksooo merged commit fb2dd46 into xbmc:master Apr 19, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Merged build finished.
Details
@ksooo ksooo deleted the ksooo:epg-load-performance branch Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.