Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-api] - add preselect params to Dialog.multiselect() and Dialog().select() #9666

Merged
merged 2 commits into from May 2, 2016

Conversation

@phil65
Copy link
Member

commented Apr 22, 2016

Requested here for example: http://forum.kodi.tv/showthread.php?tid=270814
I also have some usecases for this.

@phil65 phil65 changed the title Multiselect preselect [python-api] - add preselect params to Dialog.multiselect() and Dialog().select() Apr 22, 2016
* \n
* *Note, Returns the position of the highlighted item as an integer.\n
* \n
* example:\n
* - dialog = xbmcgui.Dialog()\n
* - ret = dialog.select('Choose a playlist', ['Playlist #1', 'Playlist #2, 'Playlist #3'])\n\n
*/
int select(const String& heading, const std::vector<String>& list, int autoclose=0);
int select(const String& heading, const std::vector<String>& list, int autoclose=0, int preselect=-1);

/**
* multiselect(heading, list [,autoclose]) -- Show a multi-select dialog.
*

This comment has been minimized.

Copy link
@MartijnKaijser

MartijnKaijser Apr 23, 2016

Member

This needs updating as well. Perhaps also add example how that preselect list should look like

@phil65 phil65 force-pushed the phil65:multiselect_preselect branch 2 times, most recently from ec94e75 to c1a63ad Apr 23, 2016
@phil65

This comment has been minimized.

Copy link
Member Author

commented May 1, 2016

jenkins build this please.
@tamland, ok to merge?

@tamland tamland merged commit 37379a1 into xbmc:master May 2, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Merged build finished.
Details
@ronie

This comment has been minimized.

Copy link
Member

commented May 4, 2016

@phil65 kodi is crashing on my end if i don't provide a preselect param in Dialog().multiselect().
can you confirm?

http://xbmclogs.com/pol4onkzz

@phil65

This comment has been minimized.

Copy link
Member Author

commented May 4, 2016

Hmm didnt notice any crashing while testing. will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.