Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skin] save skin settings early on exit #9696

Merged
merged 1 commit into from May 1, 2016

Conversation

@stefansaraev
Copy link
Contributor

commented Apr 27, 2016

this should fix the issue where skin settings may not be saved on application exit / reboot / shutdown.

cc @Montellese this is trivial but second look would be nice.

@Montellese

This comment has been minimized.

Copy link
Member

commented Apr 27, 2016

You should rather mention that the problem only happens when something crashes on exit / reboot / shutdown. When everything goes as it should, the skin settings should also be fine right?

Apart from that it looks ok.

@stefansaraev

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2016

When everything goes as it should, the skin settings should also be fine right

thats right. I'll update the comment.

@stefansaraev stefansaraev force-pushed the stefansaraev:skinsave branch from 7be721a to ddb8061 Apr 27, 2016

@stefansaraev stefansaraev added this to the Krypton 17.0-alpha1 milestone Apr 28, 2016

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented May 1, 2016

jenkins build this please

@MartijnKaijser MartijnKaijser merged commit 8b15639 into xbmc:master May 1, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Merged build finished.
Details

@stefansaraev stefansaraev deleted the stefansaraev:skinsave branch May 2, 2016

asavah added a commit to asavah/xbmc that referenced this pull request Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.