Skip to content

[addons] change behaviour of system.platform.osx and add system.platform.darwin #970

Merged
merged 1 commit into from Jun 1, 2012

5 participants

@Memphiz
Team Kodi member
Memphiz commented May 16, 2012

This changes the behaviour of the condition system.platform.osx.

Before it was true whenever it was one of ios or osx. Now its only true on osx anymore. For getting the old behaviour system.platform.darwin has to be used after this PR.

So basically we have:

system.platform.darwin - true on ios and osx
system.platform.osx - true on osx
system.platform.ios - true on ios

Hey we can delete a "TODO" comment from code - how cool :)

@Memphiz Memphiz [addons] - change system.platform.osx means osx only, system.platform…
….ios means ios only, system.platform.darwin means osx or ios
2594331
@garbear
Team Kodi member
garbear commented May 16, 2012

deleting a TODO is possible? hm, you learn something new everyday

@jmarshallnz
Team Kodi member

It would pay to comment about this in the skinning development forum - there's a thread there regarding frodo changes. We'll also need a bump for xbmc.gui.skin when this goes in (end of June window).

@Memphiz
Team Kodi member
Memphiz commented May 16, 2012

done ... but it also is valid for other addons - not only skins. How to communicate that?

@davilla
davilla commented May 16, 2012

at one time, there was a request to be able to tell an atv2/3 from a iphone/ipad.

that's why there was an system.platform.atv2

@Memphiz
Team Kodi member
Memphiz commented May 16, 2012

yeah and its still there and it has to stay :)

so system.platform.ios will go true on ios and atv2
system.platform.atv2 will go true on atv2 only ...

but imho thats offtopic ;)

@Memphiz
Team Kodi member
Memphiz commented May 28, 2012

Is there anything speaking against this change? Else i would like to queue this one up for the june milestone...

@dersphere
Team Kodi member

Not sure that I got it right but I don't need to change something in the "XBMC Log Uploader" Addon, right?
https://github.com/dersphere/script.xbmc.debug.log/blob/master/addon.py#L117 L117-L126

Sorry, I have no OSX device to test with.

@Memphiz Memphiz was assigned May 28, 2012
@Memphiz
Team Kodi member
Memphiz commented May 29, 2012

Nope you are fine. Actually the script starts to put the logs in the right directory on ios with this PR. Before it used the osx path ;)

@Memphiz Memphiz merged commit cb4aaaa into xbmc:master Jun 1, 2012
@kib kib referenced this pull request in mazkolain/spotimc Jan 16, 2013
Open

Support for Apple TV 2 #56

@tru tru added a commit to plexinc/plex-home-theater-public that referenced this pull request Jan 10, 2014
@tru tru Follow providers in search results.
Fixes #970
9bbc506
@Memphiz Memphiz deleted the Memphiz:platformdarwin branch Jan 14, 2014
@dalehamel dalehamel added a commit to RasPlex/plex-home-theatre that referenced this pull request Jan 27, 2014
@tru tru Follow providers in search results.
Fixes #970
038dd8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.