Skip to content

Conversation

bkuhls
Copy link
Contributor

@bkuhls bkuhls commented Apr 28, 2016

For a quick fix I renamed min() to cxmin() and max() to cxmax() to
prevent the conflict with the gcc definition.

Forum thread for reference:
http://forum.kodi.tv/showthread.php?tid=263884

For a quick fix I renamed min() to cxmin() and max() to cxmax() to
prevent the conflict with the gcc definition.

Forum thread for reference:
http://forum.kodi.tv/showthread.php?tid=263884
@fritsch
Copy link
Member

fritsch commented Apr 28, 2016

If that was the only thing that is problematic with gcc6.

cximage was removed from master branch ans as of now - Jarvis won't get another point release. So not sure what to do with the PR. Let's ask the RM @MartijnKaijser what do we want to do?

@MartijnKaijser
Copy link
Member

Indeed I don't forsee another point release. Master diverged way too much already for doing backports anyway.
Thank you anyway for this PR but we're gonna close it. It should still be helpful for people running into the same problem.

@stefansaraev
Copy link
Contributor

I think this should be open for some time, so its easier for people to find it. with comments locked to minimize the noise

there be some distros in next few months, compiling jarvis with gcc6

@fritsch
Copy link
Member

fritsch commented Apr 28, 2016

Yes, let's keep it open - as the work is already done.

@fritsch fritsch reopened this Apr 28, 2016
@xbmc xbmc locked and limited conversation to collaborators Apr 28, 2016
@stefansaraev stefansaraev added Type: Fix non-breaking change which fixes an issue v16 Jarvis labels Apr 28, 2016
@MartijnKaijser
Copy link
Member

Open or closed doesn't matter they can still find it
I was trying to bring down our open PR list with stuff that won't get added or is outdated

@razzeee
Copy link
Member

razzeee commented Apr 28, 2016

I also feel like @MartijnKaijser it shouldn't be open if it's not considered (anymore) to be merged at any point.

@stefansaraev
Copy link
Contributor

it is obviously easier to find it in open PRs, if something is broken for me, I never search closed PRs. most people wont. we have over 9000! and it is near impossible to find something there at github :)

I dont mind closing it, however, making other peoples lives easier does not hurt.

@bkuhls bkuhls deleted the Jarvis_gcc6 branch September 21, 2017 11:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Type: Fix non-breaking change which fixes an issue v16 Jarvis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants