Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenderManager: Fix use of unitialized variables #9754

Merged
merged 1 commit into from May 5, 2016

Conversation

Projects
None yet
3 participants
@garbear
Copy link
Member

commented May 4, 2016

RenderManager relies on VideoPlayer to initialize m_videoDelay, but this caused loss of video in my RetroPlayer branch. Also, m_width and m_height are first used uninitialized in a != comparison, so uninitialized values are unlikely to cause an issue.

Still, better to be correct than lucky.

garbear referenced this pull request in garbear/xbmc May 4, 2016

[retroplayer] - (0005) RetroPlayer core
Thanks to elpendor for RGB565 support, poisson for RAII improvements and
ChrisMyhre for catching a compile error.

The RetroPlayer commit from the retroplayer-15.2 branch (20975ad) contains a
TODO about `g_renderManager.IsStarted()` that may or may not apply still.
@FernetMenta

This comment has been minimized.

Copy link
Member

commented May 5, 2016

thanks

@FernetMenta FernetMenta merged commit 4e90409 into xbmc:master May 5, 2016

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Razzeee Razzeee added this to the Krypton 17.0-alpha2 milestone May 5, 2016

@garbear garbear deleted the garbear:rendermanager branch Jul 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.