Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Cleanup taglibtagloader a bit and fix null padded tags #9788
As I understand it the fix to nul padded ID3v1 tags problem is the removeal of TagStringHandler, a separate commit would make that clearer. :)
But what I don't understand is why exactly the same TagStringHandler code works in Jarvis. What else changed with 17 that made this an issue? The Taglib guys think our code would have had the same issue with 1.9.1, so the change to 1.10 is not the cause. Was it the VS2015 change? I guess I would need to compile Taglib 1.9.1 in VS2015 to know. @Paxxi do you understand it?
No need to dig @Paxxi I found my explanation and can be at peace. There was a change in taglib 1.10 to the way tstring.cpp String::copyFromUFT8 worked, hence how the nul padding issue appeared.
Good to drop the unnecessary and broken string handling, and thanks for the tidy-up. I will give it a bit more testing tomorrow (managed to break my dev setup).