[WIN32] get rid of SDL in XBMC #979

Merged
merged 1 commit into from Jun 6, 2012

Projects

None yet

2 participants

@wsoltys
Member
wsoltys commented May 18, 2012

this pr depends on the WINJoystick pr so ignore the first commit.
The TexturePacker still uses SDL so SDL and SDL_image isn't removed from our build dependencies yet.

I'm unsure about the ifdefs in Powermanager.cpp and AdvancedSettings.cpp. Do we still depend on SDL for full screen or can we just remove that?

@wsoltys wsoltys was assigned May 29, 2012
Member
wsoltys commented Jun 1, 2012

@jmarshallnz , @davilla : Any comments about using HAS_SDL for indicating full screen capability?

Contributor
davilla commented Jun 1, 2012

HAS_SDL will not be present on embedded and they can do full screen.

Member
wsoltys commented Jun 1, 2012

So can we remove the ifdef around full screen completely? Powermanager.cpp and AdvancedSettings.cpp that is.

Member
wsoltys commented Jun 1, 2012

btw I searched for code lines to determine endianness but found so many examples that I dunno which could be safely used. So I decided to use boost but I'm open for suggestions.

Member
wsoltys commented Jun 1, 2012

That seems to work:
#define LITTLE_ENDIAN 0x41424344UL
#define BIG_ENDIAN 0x44434241UL
#define PDP_ENDIAN 0x42414443UL
#define ENDIAN_ORDER ('ABCD')

#if ENDIAN_ORDER==BIG_ENDIAN
:)

Member
wsoltys commented Jun 3, 2012

I've kicked boost out and just disabled big endian on windows for now (unlikely that we need it soon).
I'll let the HAS_SDL ifdefs for full screen in because I dunno what happens if a user sets m_fullscreen to false via advancedsettings on embedded.
If no one objects I pull this in the next days.

Member
wsoltys commented Jun 4, 2012

@davilla : maybe replacing the ifdef HAS_SDL by something like a target embedded might be more suitable? At least for all devices which doesn't support window mode if I read it right.

@wsoltys wsoltys merged commit 6f68bde into xbmc:master Jun 6, 2012
@tru tru added a commit to RasPlex/plex-home-theatre that referenced this pull request Feb 20, 2014
@tru @LongChair tru + LongChair Make it possible to hide All Episodes in advancedsettings
We are reusing the advancedsetting <videolibrary><hideallitems>

Fixes #979
d7b9f18
@tru tru added a commit to plexinc/plex-home-theater-public that referenced this pull request Feb 25, 2014
@tru tru Make it possible to hide All Episodes in advancedsettings
We are reusing the advancedsetting <videolibrary><hideallitems>

Fixes #979
3ea68db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment