Skip to content

Refactor CD ripper code #981

Merged
4 commits merged into from Jun 1, 2012

2 participants

@ghost
ghost commented May 18, 2012

These commits refactor the cdrip code a bit.

  • make the CDDA ripper a singleton
  • make the ripper tasks CJobs
  • use cached filesystem reads instead of CDDAReader class
@jmarshallnz
Team Kodi member

Nice - just needs osx taken care of (you can safely delete the files from the projects with a text editor if you can be bothered).

Nothing obvious spotted.

@ghost
ghost commented May 19, 2012

if you are absolutely sure.. i did it once and davilla grumped.

@wsoltys
Team Kodi member
wsoltys commented May 19, 2012

I guess CDDARipJob.cpp still needs to be added to the osx and win project files.

spiff added some commits May 18, 2012
spiff changed: readd progress dialog for now
this can be reverted when we have a more suitable dialog
9e63d50
spiff changed: refactor the CD ripper code
  - make the CDDA ripper a singleton
  - make the ripper tasks CJobs
  - use cached filesystem reads instead of CDDAReader class
a1b79e7
spiff ditch the now unused CDDAReader class a3d7289
@ghost
ghost commented Jun 1, 2012

windows buildsystem work done (thanks grajen). pulling without osx buildsystem as ok'd in general by davilla.

@ghost ghost merged commit 09bd1df into xbmc:master Jun 1, 2012
@amet amet added a commit that referenced this pull request Jun 1, 2012
@amet amet [osx/ios/atv2] sync xcode projects after #981 588b070
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.