Refactor CD ripper code #981

Merged
4 commits merged into from Jun 1, 2012

Conversation

Projects
None yet
2 participants
@ghost

ghost commented May 18, 2012

These commits refactor the cdrip code a bit.

  • make the CDDA ripper a singleton
  • make the ripper tasks CJobs
  • use cached filesystem reads instead of CDDAReader class
@jmarshallnz

This comment has been minimized.

Show comment
Hide comment
@jmarshallnz

jmarshallnz May 18, 2012

Member

Nice - just needs osx taken care of (you can safely delete the files from the projects with a text editor if you can be bothered).

Nothing obvious spotted.

Member

jmarshallnz commented May 18, 2012

Nice - just needs osx taken care of (you can safely delete the files from the projects with a text editor if you can be bothered).

Nothing obvious spotted.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost May 19, 2012

if you are absolutely sure.. i did it once and davilla grumped.

ghost commented May 19, 2012

if you are absolutely sure.. i did it once and davilla grumped.

@wsoltys

This comment has been minimized.

Show comment
Hide comment
@wsoltys

wsoltys May 19, 2012

Member

I guess CDDARipJob.cpp still needs to be added to the osx and win project files.

Member

wsoltys commented May 19, 2012

I guess CDDARipJob.cpp still needs to be added to the osx and win project files.

spiff added some commits May 18, 2012

spiff
changed: readd progress dialog for now
this can be reverted when we have a more suitable dialog
spiff
changed: refactor the CD ripper code
  - make the CDDA ripper a singleton
  - make the ripper tasks CJobs
  - use cached filesystem reads instead of CDDAReader class
@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jun 1, 2012

windows buildsystem work done (thanks grajen). pulling without osx buildsystem as ok'd in general by davilla.

ghost commented Jun 1, 2012

windows buildsystem work done (thanks grajen). pulling without osx buildsystem as ok'd in general by davilla.

ghost pushed a commit that referenced this pull request Jun 1, 2012

@ghost ghost merged commit 09bd1df into xbmc:master Jun 1, 2012

amet added a commit that referenced this pull request Jun 1, 2012

tru added a commit to plexinc/plex-home-theater-public that referenced this pull request Jan 17, 2014

Merge pull request #981 from ziggimon/ext-ffmpeg-fix
Fixing DllAvCodec class for external ffmpeg

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment