Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webinterface.default] tvshows: default to poster view and use sorttitle #9853

Merged
merged 2 commits into from Oct 15, 2016

Conversation

@chewitt
Copy link
Member

chewitt commented May 21, 2016

The TVShows view has a "banner - poster - landscape" toggle at the top of the page. The toggle does not retrieve different images it simply resizes the same poster image to different sizes. Removing the toggle completely is beyond my code fu so this PR simply sets the default to poster so the page displays correctly. It also sorts using sorttitle (same as the movie page) else tvshows appear in the unsorted order they were added to the library which makes no sense.

@Montellese

This comment has been minimized.

Copy link
Member

Montellese commented May 22, 2016

Can you split the artwork change and the sorting change into two commits? Personally I use banners for tvshows as well but I'm not sure if there's a "universal" standard artwork for tvshows.

What would be really nice is if we would retrieve all available artwork (which is supported by the JSON-RPC API) and then show the proper artwork depending on the chosen artwork type.

@chewitt chewitt force-pushed the chewitt:webgui_poster branch from 78e9e9a to 4ddfff5 May 22, 2016
@chewitt

This comment has been minimized.

Copy link
Member Author

chewitt commented May 22, 2016

@Montellese - I've split the PR into two commits as requested.

@stefansaraev

This comment has been minimized.

Copy link
Contributor

stefansaraev commented Jun 1, 2016

good to go ?

@Montellese

This comment has been minimized.

Copy link
Member

Montellese commented Jun 1, 2016

Fine with me.

@stefansaraev

This comment has been minimized.

Copy link
Contributor

stefansaraev commented Jun 1, 2016

@chewitt I just tested this (with latest chrome and firefox). but default view is still banner. TVView cookie is correctly set but after (EDIT: clicking on "poster" view and) refresh it defaults back to banner view. (seems click is not triggered on a toggle somewhere, js is sorta black magic to me)
not sure if it's my browsers fault

EDIT: same without this PR. so probably unrelated bug, one of those that always hit me..

@chewitt

This comment has been minimized.

Copy link
Member Author

chewitt commented Jun 1, 2016

It's not the browser's fault as it does the same here (but didn't when I originally tested the tweak). I guess there's an underlying issue in the JavaScript as "remember view preference" has never worked (or not that I can remember - this has bugged me for a couple of years). I tried to remove the toggle entirely so tvshows matched the movies view but I couldn't figure it out. The sort tweak is fine so I can either drop the banner change or you can regard it as no less broken than it already is and merge both. Let me know what you'd prefer? :)

@stefansaraev

This comment has been minimized.

Copy link
Contributor

stefansaraev commented Jun 1, 2016

I have no preference, as I dont use webif at all :)

@MartijnKaijser MartijnKaijser merged commit 73d5787 into xbmc:master Oct 15, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-beta4 milestone Oct 15, 2016
@chewitt chewitt deleted the chewitt:webgui_poster branch May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.