Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Scale for HQ scaling above #9915

Merged
merged 2 commits into from Jun 7, 2016

Conversation

Projects
None yet
6 participants
@fritsch
Copy link
Member

commented Jun 5, 2016

This setting is fully confusing for users as hq scaling is a waste of resources if source and target nearly have the very same dimensions. It puts immense load on the GPU while visual quality improvement is not given at all. There is no need to process a 1080p file with a 6x6 convolution shader if the output image is still ~ 1080p.

Also the barely existing documentation is confusing to the user, too.

Example:
1080p Output resolution.

Video: 1280x720
(1920 - 1280) / 1920 = 33%
(1080 - 720) / 1080 = 33 %

Video: 1920x1080
(1920 - 1920) / 1920 = 0 %
(1080 - 1080) / 1080 = 0%

In code the minimum of both values is chosen.

In short a default value of 20% will use HQ scaling when scaling 720p to 1080p or when scaling 576i to 1080p. It won't use hq scalers starting with (1536 width) for this 1080p example.

@@ -16647,7 +16647,7 @@ msgstr ""
#. Description of setting with label #13435 "Enable HQ Scalers for scaling above"
#: system/settings/settings.xml
msgctxt "#36154"
msgid "Use high quality scalers when upscaling a video by at least this percentage."
msgid "Use high quality scalers when upscaling a video by at least this percentage. A value below 5% makes limited sense as video is processed with high load whithout any visible picture quality improvements."

This comment has been minimized.

Copy link
@MartijnKaijser

MartijnKaijser Jun 5, 2016

Member

.... high CPU load ....

This comment has been minimized.

Copy link
@fritsch

fritsch Jun 5, 2016

Author Member

It's GPU load - will add.

@fritsch fritsch force-pushed the fritsch:defaultscale branch from 54167ef to 9b740df Jun 5, 2016

@FernetMenta

This comment has been minimized.

Copy link
Member

commented Jun 5, 2016

makes sense

@@ -16647,7 +16647,7 @@ msgstr ""
#. Description of setting with label #13435 "Enable HQ Scalers for scaling above"
#: system/settings/settings.xml
msgctxt "#36154"
msgid "Use high quality scalers when upscaling a video by at least this percentage."
msgid "Use high quality scalers when upscaling a video by at least this percentage. A value below 5% makes limited sense as video is processed with high GPU load whithout any visible picture quality improvements."

This comment has been minimized.

Copy link
@ghost

ghost Jun 5, 2016

whithout -> without

This comment has been minimized.

Copy link
@ghost

ghost Jun 5, 2016

also 'limited sense' is strange english :) 'little sense' is more common among mortals.

@kq01526

This comment has been minimized.

Copy link

commented Jun 5, 2016

@da-anda

This comment has been minimized.

Copy link
Member

commented Jun 5, 2016

minimum value of 0 is required to turn it off atm, but do we still need he "off" state with all the enumeration etc we're having in place these days? And platforms that don't support HQ scalers will hide the entire setting anyways.

LANG: Add a bit more description for HQ scaling above
v1: Add GPU word
v2: Fix bad english wording (thx davilla)

@fritsch fritsch force-pushed the fritsch:defaultscale branch from 9b740df to 29c21d3 Jun 5, 2016

@fritsch

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2016

@kq01526 Here is a math work for you:

Which value do you have to setup in per cent, so that on a 1400x1050 resolution a video of 1366x1024 is upscaled via HQ scalers. If you can answer this correctly - you are ready to answer me, why we have 10% steps and not 5% and not 1%.

Awaiting your answer.

@kq01526

This comment has been minimized.

Copy link

commented Jun 5, 2016

@fritsch wrote:

@kq01526 Here is a math work for you:

Which value do you have to setup in per cent, so that on a 1400x1050 resolution a video of 1366x1024 is upscaled via HQ scalers.

Whooops, maybe you should have removed your math from the first post prior to asking me.

Because now I can simply be lazy and just replace the numbers:

@fritsch wrote:

If you can answer this correctly

I guess I can:

1050p Output resolution.

Video: 1366x1024
(1400 - 1366) / 1400 = 2.43%
(1050 - 1024) / 1050 = 2.48%

@fritsch wrote:

you are ready to answer me, why we have 10% steps and not 5% and not 1%.

Awaiting your answer.

Sorry, I am not ready to answer you.

I still don't get why we have 10% steps and not 5% nor 1% steps.

Please explain.

Awaiting your answer.

Regards

@fritsch

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2016

The question is as follows:

Given an amount of N default CAE resolutions M. Which value p of stepsize is needed so that one can seperate all elements of M from each other while uniting resolution that have the same width?

In short: 10 is enough to do so.

Asked differently: Find two CAE modes that you cannot separate with a difference of 10 %.

@fritsch

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2016

jenkins build this please

@fritsch fritsch merged commit 0078a24 into xbmc:master Jun 7, 2016

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.