Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed: get rid of PlayListPlayer include in Application.h #9947

Merged
merged 1 commit into from Jun 11, 2016

Conversation

@notspiff
Copy link
Contributor

notspiff commented Jun 11, 2016

before: touch PlayListPlayer.h -> 156 objects rebuilt
after: touch PlayListPlayer.h -> 42 objects rebuilt

@FernetMenta

This comment has been minimized.

Copy link
Member

FernetMenta commented Jun 11, 2016

jenkins build this please

@hudokkow

This comment has been minimized.

Copy link
Member

hudokkow commented Jun 11, 2016

/Users/Shared/jenkins/workspace/IOS/xbmc/platform/darwin/ios-common/AnnounceReceiver.mm:164:19: error: use of undeclared identifier 'g_playlistPlayer'
int current = g_playlistPlayer.GetCurrentSong();
^
/Users/Shared/jenkins/workspace/IOS/xbmc/platform/darwin/ios-common/AnnounceReceiver.mm:168:46: error: use of undeclared identifier 'g_playlistPlayer'
[item setValue:[NSNumber numberWithInt:g_playlistPlayer.GetPlaylist(g_playlistPlayer.GetCurrentPlaylist()).size()] forKey:@"total"];
^
/Users/Shared/jenkins/workspace/IOS/xbmc/platform/darwin/ios-common/AnnounceReceiver.mm:168:75: error: use of undeclared identifier 'g_playlistPlayer'
[item setValue:[NSNumber numberWithInt:g_playlistPlayer.GetPlaylist(g_playlistPlayer.GetCurrentPlaylist()).size()] forKey:@"total"];

http://jenkins.kodi.tv/job/IOS/7528/consoleFull

before: touch PlayListPlayer.h -> 156 objects rebuilt
after: touch PlayListPlayer.h -> 42 objects rebuilt
@notspiff

This comment has been minimized.

Copy link
Contributor Author

notspiff commented Jun 11, 2016

include added

On Sat, Jun 11, 2016 at 3:58 PM, Cristiano A. Silva <
notifications@github.com> wrote:

/Users/Shared/jenkins/workspace/IOS/xbmc/platform/darwin/ios-common/AnnounceReceiver.mm:164:19:
error: use of undeclared identifier 'g_playlistPlayer'
int current = g_playlistPlayer.GetCurrentSong();
^
/Users/Shared/jenkins/workspace/IOS/xbmc/platform/darwin/ios-common/AnnounceReceiver.mm:168:46:
error: use of undeclared identifier 'g_playlistPlayer'
[item setValue:[NSNumber
numberWithInt:g_playlistPlayer.GetPlaylist(g_playlistPlayer.GetCurrentPlaylist()).size()]
forKey:@"total"];
^
/Users/Shared/jenkins/workspace/IOS/xbmc/platform/darwin/ios-common/AnnounceReceiver.mm:168:75:
error: use of undeclared identifier 'g_playlistPlayer'
[item setValue:[NSNumber
numberWithInt:g_playlistPlayer.GetPlaylist(g_playlistPlayer.GetCurrentPlaylist()).size()]
forKey:@"total"];

http://jenkins.kodi.tv/job/IOS/7528/consoleFull


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#9947 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AFktYJIPiuXUA3qG3m4F4gaQ0_od_57Tks5qKr8fgaJpZM4IzcKc
.

@notspiff notspiff force-pushed the notspiff:remove_pp_include branch from c7fe92c to 6e5c67a Jun 11, 2016
@MartijnKaijser

This comment has been minimized.

Copy link
Member

MartijnKaijser commented Jun 11, 2016

jenkins build this please

@MartijnKaijser MartijnKaijser merged commit af1fef1 into xbmc:master Jun 11, 2016
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
default Merged build finished.
Details
@notspiff notspiff deleted the notspiff:remove_pp_include branch Jun 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.