Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] Fix GenerateVersionedFiles #9953

Merged
merged 1 commit into from Jun 11, 2016

Conversation

@fetzerch
Copy link
Member

fetzerch commented Jun 11, 2016

This commit fixes issues with GenerateVersionedFiles:

  • The generation step is called twice when a dependent file is changed.
  • The generated files are always outdated when the input file is not modified but the timestamp is updated (touch).
  • On OSX the compileinfo target fails with "Problem configuring file" when using the Xcode generator.

GenerateVersionedFiles internally used configure_file to generate the output files. configure_file itself does dependency tracking which seems to interfere with the dependencies of add_custom_command. When an input file is changed, the script is executed and generates the
files. This however causes the other files to appear outdated as well and the generation is triggered again.

cc: @hudokkow

This commit fixes issues with GenerateVersionedFiles:
- The generation step is called twice when a dependent file is changed.
- The generated files are always outdated when the input file is
  not modified but the timestamp is updated (touch).
- On OSX the compileinfo target fails with "Problem configuring file"
  when using the Xcode generator.

GenerateVersionedFiles internally used configure_file to generate the
output files. configure_file itself does dependency tracking which
seems to interfere with the dependencies of add_custom_command. When
an input file is changed, the script is executed and generates the
files. This however causes the other files to appear outdated as well
and the generation is triggered again.
@fetzerch fetzerch added this to the Krypton 17.0-alpha2 milestone Jun 11, 2016
@fetzerch fetzerch merged commit 2229bcd into xbmc:master Jun 11, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
@fetzerch fetzerch deleted the fetzerch:cmake_osx_fix_xcodebuild branch Jun 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.