added MusicPlayer.FilenameAndPath infolabel. #997

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@nuka1195
Contributor

nuka1195 commented May 23, 2012

added MusicPlayer.FilenameAndPath infolabel. i did it so it supports offset. (the reason for the shifting of id's)

added MusicPlayer.FilenameAndPath infolabel. i did it so it supports …
…offset. (the reason for the shifting of id's)
@nuka1195

This comment has been minimized.

Show comment Hide comment
@nuka1195

nuka1195 May 23, 2012

Contributor

so i didn't have to change a line further in that limited the labels that worked with .offset() MUSICPLAYER_ALBUM_ARTIST

ok will make the change

Contributor

nuka1195 commented May 23, 2012

so i didn't have to change a line further in that limited the labels that worked with .offset() MUSICPLAYER_ALBUM_ARTIST

ok will make the change

@nuka1195

This comment has been minimized.

Show comment Hide comment
@nuka1195

nuka1195 May 23, 2012

Contributor

i was considering making player.* work offset and just factor out the need for musicplayer.* and videoplayer.*. what do you think?

Contributor

nuka1195 commented May 23, 2012

i was considering making player.* work offset and just factor out the need for musicplayer.* and videoplayer.*. what do you think?

@HitcherUK

This comment has been minimized.

Show comment Hide comment
@HitcherUK

HitcherUK May 23, 2012

Contributor

@nuka1195 The removal of musicplayer and videoplayer is actually planned at some point.

Contributor

HitcherUK commented May 23, 2012

@nuka1195 The removal of musicplayer and videoplayer is actually planned at some point.

@nuka1195

This comment has been minimized.

Show comment Hide comment
@nuka1195

nuka1195 May 24, 2012

Contributor

Good, I think it makes more sense.

Contributor

nuka1195 commented May 24, 2012

Good, I think it makes more sense.

@amet

This comment has been minimized.

Show comment Hide comment
@amet

amet Sep 1, 2012

Contributor

@ronie is this needed in skins?

@nuka1195 it really would help if we knew what you intend to do with these additions, adding it just for a sake of extra code is not what we would like to do. if there is a valid reason for them let us know please

Contributor

amet commented Sep 1, 2012

@ronie is this needed in skins?

@nuka1195 it really would help if we knew what you intend to do with these additions, adding it just for a sake of extra code is not what we would like to do. if there is a valid reason for them let us know please

@ronie

This comment has been minimized.

Show comment Hide comment
@ronie

ronie Sep 3, 2012

Member

we already have Player.Filenameandpath
no need to duplicate it to MusicPlayer.*

Member

ronie commented Sep 3, 2012

we already have Player.Filenameandpath
no need to duplicate it to MusicPlayer.*

@ronie ronie closed this Sep 3, 2012

@nuka1195

This comment has been minimized.

Show comment Hide comment
@nuka1195

nuka1195 Mar 20, 2013

Contributor

these are need by me, can you open and reconsider.

Player.Filenameandpath doesn't support offset() does it?

Contributor

nuka1195 commented Mar 20, 2013

these are need by me, can you open and reconsider.

Player.Filenameandpath doesn't support offset() does it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment