Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Browser Support #100

Open
bhurler1 opened this issue May 29, 2019 · 7 comments

Comments

@bhurler1
Copy link

commented May 29, 2019

Brave is chromium based and has some small quirks. Overall seems to work really well out of the box, only having minor issues such as the search input not automatically focusing. Would be great to add official support.

Thanks!

@poikilos

This comment has been minimized.

Copy link

commented Jun 3, 2019

I don't know whether there is "official support" yet, but it seems to work fine after some cross-browser issues were resolved in the betas:

  • Sync from Mozilla-based to Chromium-based browsers (including Brave) is fixed with #84
  • Sync from Chromium-based (including Brave) to Mozilla-based browsers is fixed with #93 (as of 1.5.0beta7)
@bhurler1

This comment has been minimized.

Copy link
Author

commented Jun 3, 2019

Correct. @nero120 asked me to make a feature request thread for people to upvote if they wanted it added officially. Then they can see how much the feature is requested by users and discern if they need to allocate the time to fixing the remaining minor issues.

@nero120

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Until Brave is supported there could well be issues that are not immediately obvious, so if you want to use xBrowserSync with it make sure you take regular back ups just in case! 😄

@nero120 nero120 added this to the v1.6.0 milestone Jun 28, 2019

@yz778

This comment has been minimized.

Copy link

commented Jul 21, 2019

I'm using xBrowserSync across Brave (win10), Chrome (win10), and Chromium (linux) -- and happy to report that it's working well.

If you're using Brave, consider turning off Brave's sync. I've had Brave sync on while xBrowserSync was on, and experienced bookmarks duplicated and folders being partially duplicated. If I can reproduce this, i'll file a proper bug report.

@nero120

This comment has been minimized.

Copy link
Member

commented Jul 21, 2019

@yz778 xBrowserSync does not support using other sync tools under any circumstances, doing so will always lead to duplication as the native APIs are triggered by those sync tools which then trigger xBrowserSync.

@yz778

This comment has been minimized.

Copy link

commented Jul 21, 2019

@nero120, agree and understood. Suggested feature when Brave support is official -- to detect that Brave Sync is on and give a warning.

@nero120

This comment has been minimized.

Copy link
Member

commented Jul 21, 2019

@yz778 that's not possible unfortunately as there's no API available for any browser that can determine that. However in v1.5.0 I have included a warning to disable any active syncing tools:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.