Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I'm working on an native Android application #108

Open
letroll opened this issue Jul 5, 2019 · 1 comment

Comments

@letroll
Copy link

commented Jul 5, 2019

Hello,

After tested the current Android application and see some issues:

I started working on a native application, and I would like to know if you are interested than I share my works

@nero120

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

Hi @letroll, I've considered building a native app in the past, there's a couple of reasons why I decided to stick with Cordova but the main one is that having a unified code base means far less work to update all platforms. For now, the app is simple enough that it can share the code base with the extensions so I don't think there's a benefit in separating it out. Dev time is limited and must be utilised to complete implementation of core features before looking at nice to haves.

Regarding the issues:

  • #47 will be resolved in v1.5.0 which I'm currently working on (#25 may also be resolved at this point).
  • #53 cannot be resolved due to segregation of app data/no equivalent mobile api to web extensions.
  • #29 will be resolved in future as part of the plan to support more services than just xBrowserSync services.

The interesting one is #78, this used to work but doesn't any more. It uses the cordova InAppBrowser plugin to open a hidden web view, load a url, then grab metadata from the loaded DOM before closing the web view. It relies on the loadstop event listener to fire once the url has finished loading but this no longer seems to work which is why xBrowserSync can no longer automatically populate bookmark metadata.

If you are able or willing to look into this issue then it would be a massive help! Otherwise no worries, if you still want to develop a native app then i'd be interested to see what you produce.

@nero120 nero120 added the question label Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.