Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have server enforce SSH zone separation #7247

Merged
merged 1 commit into from Nov 4, 2022

Conversation

jjohnson42
Copy link
Member

When a client requests a zone's ssh credentials, make sure the client is consistent with the specified zone.

Per github user salben21

The PR is to fix issue 7246

The modification include

##item1

##item2

The UT result

##The UT output##

Please remove this line and below if fix issue

Please remove this line and above for tasks or features

The PR is for task #xxx or to implement feature #xxx

##Feature description##

The content of the PR:

  • ##The mini-design link
  • ##The basic code logic

The UT result

##The UT output##

When a client requests a zone's ssh credentials, make sure the
client is consistent with the specified zone.

Per github user salben21
Copy link
Member

@besawn besawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the conditions described in the original issue (#7246) and the fix contained in this pull request.

The change in this pull request adds additional checking to enforce the following:
1.) Disallow distribution of root keys between zones.
2.) Disallow distribution of root keys within a zone when sshbetweennodes=no for that zone.

Thank you @salben21 and @jjohnson42 for the contributions.

@besawn besawn merged commit d58445a into xcat2:master Nov 4, 2022
1 check passed
@besawn besawn added this to the 2.16.5 milestone Nov 4, 2022
@besawn besawn linked an issue Mar 7, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsufficient check in credentials.pm
2 participants