Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd end to end `xcversion install` test. #365
Conversation
This comment has been minimized.
This comment has been minimized.
Thanks for the PR! IIRC for the downloads you just need any old Apple ID, so we could probably create one that’s throwaway with 2FA disabled |
This comment has been minimized.
This comment has been minimized.
@milch You are now an admin |
This comment has been minimized.
This comment has been minimized.
Awesome, thanks! I'll merge this now and set up the Apple ID. Thanks again @Kesin11! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Kesin11 commentedNov 9, 2019
ref #361
Add end to end test with GitHub Actions. It checks
xcversion install
works properly with several Xcode versions.If you want to check result of this test, you can see it in my forked repository.
Kesin11#4
@milch or someone who has admin access to this repository please do setup for enable this test.
XCODE_INSTALL_USER
andXCODE_INSTALL_PASSWORD
to repository secrets.