Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end to end `xcversion install` test. #365

Merged
merged 1 commit into from Nov 23, 2019

Conversation

@Kesin11
Copy link
Contributor

Kesin11 commented Nov 9, 2019

ref #361

Add end to end test with GitHub Actions. It checks xcversion install works properly with several Xcode versions.

If you want to check result of this test, you can see it in my forked repository.
Kesin11#4

@milch or someone who has admin access to this repository please do setup for enable this test.

  1. Enable GitHub Actions. This feature is still beta.
  2. Get an AppleID with 2FA disabled.
  3. Set XCODE_INSTALL_USER and XCODE_INSTALL_PASSWORD to repository secrets.
@milch

This comment has been minimized.

Copy link
Collaborator

milch commented Nov 9, 2019

Thanks for the PR! 🥇 This will really help increase our confidence in the PRs we get here.
I have push access but I’m not actually an admin so I can’t enable GitHub Actions. @joshdholtz help?

IIRC for the downloads you just need any old Apple ID, so we could probably create one that’s throwaway with 2FA disabled

@joshdholtz

This comment has been minimized.

Copy link
Member

joshdholtz commented Nov 14, 2019

@milch You are now an admin 😊 Feel free to DM me on Twitter if you need something faster in the future 😉

@milch

This comment has been minimized.

Copy link
Collaborator

milch commented Nov 23, 2019

Awesome, thanks! I'll merge this now and set up the Apple ID.

Thanks again @Kesin11!

@milch milch merged commit 18c402c into xcpretty:master Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.