New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the brew instructions for the mac #47

Merged
merged 1 commit into from Apr 5, 2018

Conversation

Projects
None yet
2 participants
@benmatselby
Contributor

benmatselby commented Apr 5, 2018

Homebrew recommend we install Xdebug via pecl and not via brew

https://brew.sh/2018/01/19/homebrew-1.5.0/

@derickr

Thanks — Instead of removing the whole section, would you think it's better to change it to "Installation on Mac OS X", leave the instructions for homebrew for PHP, and then say to use PECL for Xdebug?

@benmatselby

This comment has been minimized.

Show comment
Hide comment
@benmatselby

benmatselby Apr 5, 2018

Contributor

Hi @derickr

There is not much to leave, other than to follow the pecl instructions. Even the link to how to install php via brew is now redundant..

So I can update and leave the heading and explain the home-brew change and to just follow the pecl install?

Contributor

benmatselby commented Apr 5, 2018

Hi @derickr

There is not much to leave, other than to follow the pecl instructions. Even the link to how to install php via brew is now redundant..

So I can update and leave the heading and explain the home-brew change and to just follow the pecl install?

@derickr

That works! I'm sure I have made references to this link location before, so at least the xdebug.org/docs/install#mac URI/anchor keeps working, and gives correct information.

@benmatselby

This comment has been minimized.

Show comment
Hide comment
@benmatselby

benmatselby Apr 5, 2018

Contributor

No worries, give me an hour

Contributor

benmatselby commented Apr 5, 2018

No worries, give me an hour

@benmatselby

This comment has been minimized.

Show comment
Hide comment
@benmatselby

benmatselby Apr 5, 2018

Contributor

@derickr Is that any better? Although I have now noticed that there is trailing white space changes due to trimming. Do you mind, or want me to add the trailing white space again?

Contributor

benmatselby commented Apr 5, 2018

@derickr Is that any better? Although I have now noticed that there is trailing white space changes due to trimming. Do you mind, or want me to add the trailing white space again?

@derickr

derickr requested changes Apr 5, 2018 edited

Yes! I don't mind the white space trimming, but would prefer if it was a separate commit (first or last, I don't mind). I would also suggest to make use of a hyperlink to refer back to #pecl — this is HTML after all :-)

Show outdated Hide outdated html/docs/include/features.php
Remove the brew instructions for the mac
Homebrew recommend we install Xdebug via pecl and not via brew

https://brew.sh/2018/01/19/homebrew-1.5.0/
@benmatselby

This comment has been minimized.

Show comment
Hide comment
@benmatselby

benmatselby Apr 5, 2018

Contributor

Done, hopefully :)

Contributor

benmatselby commented Apr 5, 2018

Done, hopefully :)

@derickr derickr merged commit 1fe124e into xdebug:master Apr 5, 2018

@derickr

This comment has been minimized.

Show comment
Hide comment
@derickr

derickr Apr 5, 2018

Contributor

Thanks! I've merged it.

Contributor

derickr commented Apr 5, 2018

Thanks! I've merged it.

@benmatselby benmatselby deleted the benmatselby:brew-change branch Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment