diff --git a/src/debugger/com.c b/src/debugger/com.c index 49c80a854..2b42f44c5 100644 --- a/src/debugger/com.c +++ b/src/debugger/com.c @@ -374,11 +374,11 @@ static void xdebug_init_normal_debugger(xdebug_str *connection_attempts) } xdebug_log(XLOG_CHAN_DEBUG, XLOG_INFO, "Checking remote connect back address."); - if (XINI_DBG(remote_addr_header) && XINI_DBG(remote_addr_header)[0]) { - header = XINI_DBG(remote_addr_header); - xdebug_log(XLOG_CHAN_DEBUG, XLOG_INFO, "Checking user configured header '%s'.", XINI_DBG(remote_addr_header)); + if (XINI_DBG(client_discovery_header) && XINI_DBG(client_discovery_header)[0]) { + header = XINI_DBG(client_discovery_header); + xdebug_log(XLOG_CHAN_DEBUG, XLOG_INFO, "Checking user configured header '%s'.", XINI_DBG(client_discovery_header)); - remote_addr = zend_hash_str_find(Z_ARRVAL(PG(http_globals)[TRACK_VARS_SERVER]), XINI_DBG(remote_addr_header), HASH_KEY_STRLEN(XINI_DBG(remote_addr_header))); + remote_addr = zend_hash_str_find(Z_ARRVAL(PG(http_globals)[TRACK_VARS_SERVER]), XINI_DBG(client_discovery_header), HASH_KEY_STRLEN(XINI_DBG(client_discovery_header))); } if (!remote_addr) { header = "HTTP_X_FORWARDED_FOR"; diff --git a/src/debugger/debugger.h b/src/debugger/debugger.h index 0a202e023..b8a5f10c9 100644 --- a/src/debugger/debugger.h +++ b/src/debugger/debugger.h @@ -54,7 +54,7 @@ typedef struct _xdebug_debugger_settings_t { zend_long client_port; /* 9000 */ char *client_host; /* localhost */ zend_bool discover_client_host; /* (try to) connect back to the HTTP requestor */ - char *remote_addr_header; /* User configured header to check for forwarded IP address */ + char *client_discovery_header; /* User configured header to check for forwarded IP address */ zend_long connect_timeout_ms; /* Timeout in MS for remote connections */ char *ide_key_setting; /* Set through php.ini and friends */ diff --git a/tests/debugger/bug01656.phpt b/tests/debugger/bug01656.phpt index e421aa643..d82fcd34b 100644 --- a/tests/debugger/bug01656.phpt +++ b/tests/debugger/bug01656.phpt @@ -5,7 +5,7 @@ I_LIKE_COOKIES=127.0.0.1, 127.0.0.2 XDEBUG_CONFIG="idekey=foobar" --INI-- xdebug.mode=debug -xdebug.remote_addr_header=I_LIKE_COOKIES +xdebug.client_discovery_header=I_LIKE_COOKIES xdebug.discover_client_host=1 xdebug.client_port=9999 --FILE-- diff --git a/tests/debugger/remote_log-unix-2.phpt b/tests/debugger/remote_log-unix-2.phpt index 841997e99..ec305c5fd 100644 --- a/tests/debugger/remote_log-unix-2.phpt +++ b/tests/debugger/remote_log-unix-2.phpt @@ -14,7 +14,7 @@ xdebug.log={TMPDIR}/{RUNID}remote-unix.txt xdebug.discover_client_host=1 xdebug.client_host=unix:///tmp/xdbg.sock xdebug.client_port=0 -xdebug.remote_addr_header=I_LIKE_COOKIES +xdebug.client_discovery_header=I_LIKE_COOKIES --FILE--