New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make remote log immutable for bug00932 test #444

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@NoodlesNZ
Copy link

NoodlesNZ commented Feb 4, 2019

Even with chmod 0, the log can still be written to. By adding the immutable attribute to the file, this fixes the problem and the test runs as expected.

Make remote log immutable for bug00932 test
Even with chmod 0, the log can still be written to. By adding the immutable attribute to the file, this fixes the problem and the test runs as expected.
@derickr

This comment has been minimized.

Copy link
Contributor

derickr commented Feb 5, 2019

I don't understand why you can write to files with chmod(0), unless you're running as root?

In any case, this PR can not be merged because it breaks Travis tests: https://travis-ci.org/xdebug/xdebug/jobs/488706238#L976

@NoodlesNZ

This comment has been minimized.

Copy link
Author

NoodlesNZ commented Feb 7, 2019

I was running as root, which had worked in the past. I'll fix this problem on our CI, rather than pushing back to upstream as the fix doesn't appear to work on Travis.

@NoodlesNZ NoodlesNZ closed this Feb 7, 2019

@NoodlesNZ NoodlesNZ deleted the NoodlesNZ:patch-1 branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment