Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #1680: Update var dumping routines to include relevant information for interned strings and immutable arrays #486

Merged
merged 2 commits into from Aug 10, 2019

Conversation

@krakjoe
Copy link
Contributor

commented Jul 10, 2019

Prompted by this question

It's not really appropriate to display a refcount for values that are not refcounted, so for interned strings and immutable arrays, show something relevant maybe ?

There's no test, the immutable arrays part would be dependent on opcache, and I'm not familiar enough with CI to know how that is setup.

@krakjoe

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

Before I spend time fixing those failures, is this something that looks useful and if so do you have a preferred format ? (possibly rc=interned|immutable|%d produces more compatible output)

@derickr
Copy link
Contributor

left a comment

Hey — yes, the idea sounds good. Should have been done ages ago. TBH, I am thinking to just use %s for all these differences in the EXPECTF sections, as it would mean I can re-join tests that I had to split out already. It's going to be a little bit of a pain to do.

It's unlikely that I'll merge this for Xdebug 2.8 though, as I want to be able to get that out soonish.

I would also prefer having a ticket (through https://bugs.xdebug.org), and use a commit message in the form of Fixed issue #nr: <description>

Show resolved Hide resolved xdebug_var.c Outdated
@krakjoe

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

okay, I'll put some more time into this and finish it up nicely ...

@krakjoe krakjoe force-pushed the krakjoe:dump-interned-immutable-info branch 4 times, most recently from d4afa45 to 573b4d3 Jul 10, 2019

Show resolved Hide resolved xdebug_var.c Outdated
Show resolved Hide resolved xdebug_var.c Outdated

@krakjoe krakjoe force-pushed the krakjoe:dump-interned-immutable-info branch 8 times, most recently from 3178b01 to e96a57e Jul 10, 2019

@krakjoe

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

Travis is only failing because of 7.4snapshot, everything else looks green (as usual av is 1 year behind) ... looks done to me ...

@krakjoe krakjoe changed the title include interned/immutable info in dump output Fixed issue #1680: Update var dumping routines to include relevant information for interned strings and immutable arrays Jul 10, 2019

@krakjoe krakjoe force-pushed the krakjoe:dump-interned-immutable-info branch from e96a57e to a8017cd Jul 11, 2019

krakjoe and others added some commits Jul 10, 2019

Fixed issue #1680: Update var dumping routines to include relevant in…
…formation for interned strings and immutable arrays

@derickr derickr force-pushed the krakjoe:dump-interned-immutable-info branch from a8017cd to d7121f8 Aug 5, 2019

@derickr derickr merged commit d7121f8 into xdebug:master Aug 10, 2019

7 of 8 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci: PHP 7 1 with opcache Your tests passed on CircleCI!
Details
ci/circleci: PHP 7 1 without opcache Your tests passed on CircleCI!
Details
ci/circleci: PHP 7 2 with opcache Your tests passed on CircleCI!
Details
ci/circleci: PHP 7 2 without opcache Your tests passed on CircleCI!
Details
ci/circleci: PHP 7 3 with opcache Your tests passed on CircleCI!
Details
ci/circleci: PHP 7 3 without opcache Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

derickr added a commit that referenced this pull request Aug 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.