Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix issue #1726: memory leaks in error code paths fix proposal. #531
derickr left a comment
Thanks for looking into this!
The places to free memory have been correctly identified, but I've issue with the way how they have been addressed. I've added a few pointers.
In general, I would also like to see test cases for each of these situations, and preferably have the valgrind output that demonstrates these errors as part of the bug report. I am keen on making sure current bugs are covered by test cases, so that the same issue will not get reintroduced. I would also suggest to have at least one commit per specific memory leaking instance, in case having a distinct xdebug bugs issue is too much overkill (which I think it is, in this case).