Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate code to node 10 ~ 12 #92
Conversation
This comment has been minimized.
This comment has been minimized.
I will work on the macros for node version checking. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I know, node 12 dropped some codes and then the old one's will not work anymore, the macros will be need to check the node version (I will make another commit to fix that). |
This comment has been minimized.
This comment has been minimized.
If this is too much work we can drop support of older versions. |
This comment has been minimized.
This comment has been minimized.
It's not, I did the changes already and it's building on node +6, I replaced the val->ToObject and other conversions with Nan::To, and other Nan functions, the only problem was String::Concat, I changed it to use a macro to add Isolate::GetCurrent() if it's node +10. Nan::MakeCallback is deprecated and I replaced it in favor of AsyncResource::runInAsyncScope and seens to be working. |
This comment has been minimized.
This comment has been minimized.
also node 6 is deprecated https://nodejs.org/en/about/releases/ |
mjschutz commentedOct 24, 2019
I update the code to build/run on node 12 (and 10), did some tests, but need more tests to do. The code can be changed to have macros to allow building for multiple versions of node (like I did for BooleanValue).
Works on NW.js too, I'm working on a system for the place I work and I will use this module (on NW.js).