Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update code to node 10 ~ 12 #92
I update the code to build/run on node 12 (and 10), did some tests, but need more tests to do. The code can be changed to have macros to allow building for multiple versions of node (like I did for BooleanValue).
Works on NW.js too, I'm working on a system for the place I work and I will use this module (on NW.js).
It's not, I did the changes already and it's building on node +6, I replaced the val->ToObject and other conversions with Nan::To, and other Nan functions, the only problem was String::Concat, I changed it to use a macro to add Isolate::GetCurrent() if it's node +10.
Nan::MakeCallback is deprecated and I replaced it in favor of AsyncResource::runInAsyncScope and seens to be working.