From fb28d69b5d5201e7d909bb43dfd87d0d9e1850b0 Mon Sep 17 00:00:00 2001 From: carmenjyuen Date: Thu, 30 Nov 2017 17:04:17 -0800 Subject: [PATCH 1/5] Added card_uri and updated resource_property to match documentation except for Lead Gen and App Download card --- twitter_ads/creative.py | 133 +++++++++++++++++++++++++--------------- 1 file changed, 84 insertions(+), 49 deletions(-) diff --git a/twitter_ads/creative.py b/twitter_ads/creative.py index 1769c26..7a98757 100644 --- a/twitter_ads/creative.py +++ b/twitter_ads/creative.py @@ -79,18 +79,22 @@ class Video(Resource, Persistence): # video properties # read-only +resource_property(Video, 'aspect_ratio', readonly=True) +resource_property(Video, 'created_at', readonly=True, transform=TRANSFORM.TIME) +resource_property(Video, 'deleted', readonly=True, transform=TRANSFORM.BOOL) +resource_property(Video, 'description') +resource_property(Video, 'duration', readonly=True) resource_property(Video, 'id', readonly=True) -resource_property(Video, 'tweeted', readonly=True, transform=TRANSFORM.BOOL) +resource_property(Video, 'media_key', readonly=True) +resource_property(Video, 'poster_url', readonly=True) +resource_property(Video, 'preview_url', readonly=True) resource_property(Video, 'ready_to_tweet', readonly=True, transform=TRANSFORM.BOOL) -resource_property(Video, 'duration', readonly=True) resource_property(Video, 'reasons_not_servable', readonly=True) -resource_property(Video, 'preview_url', readonly=True) -resource_property(Video, 'created_at', readonly=True, transform=TRANSFORM.TIME) +resource_property(Video, 'tweeted', readonly=True, transform=TRANSFORM.BOOL) resource_property(Video, 'updated_at', readonly=True, transform=TRANSFORM.TIME) -resource_property(Video, 'deleted', readonly=True, transform=TRANSFORM.BOOL) # writable +resource_property(Video, 'poster_image_media_id') resource_property(Video, 'title') -resource_property(Video, 'description') resource_property(Video, 'video_media_id') @@ -113,7 +117,6 @@ class AccountMedia(Resource, Persistence): # writable resource_property(AccountMedia, 'media_id') resource_property(AccountMedia, 'video_id') -resource_property(AccountMedia, 'vast_url') resource_property(AccountMedia, 'creative_type') @@ -127,17 +130,17 @@ class MediaCreative(Resource, Persistence): # video properties # read-only -resource_property(MediaCreative, 'id', readonly=True) + +resource_property(MediaCreative, 'approval_status', readonly=True) resource_property(MediaCreative, 'created_at', readonly=True, transform=TRANSFORM.TIME) -resource_property(MediaCreative, 'updated_at', readonly=True, transform=TRANSFORM.TIME) resource_property(MediaCreative, 'deleted', readonly=True, transform=TRANSFORM.BOOL) -resource_property(MediaCreative, 'approval_status', readonly=True) - - +resource_property(MediaCreative, 'id', readonly=True) +resource_property(MediaCreative, 'serving_status', readonly=True) +resource_property(MediaCreative, 'updated_at', readonly=True, transform=TRANSFORM.TIME) # writable -resource_property(MediaCreative, 'line_item_id') resource_property(MediaCreative, 'account_media_id') resource_property(MediaCreative, 'landing_url') +resource_property(MediaCreative, 'line_item_id') class WebsiteCard(Resource, Persistence): @@ -151,16 +154,23 @@ class WebsiteCard(Resource, Persistence): # website card properties # read-only resource_property(WebsiteCard, 'id', readonly=True) -resource_property(WebsiteCard, 'preview_url', readonly=True) +resource_property(WebsiteCard, 'image', readonly=True) +resource_property(WebsiteCard, 'image_display_height', readonly=True) +resource_property(WebsiteCard, 'image_display_width', readonly=True) +resource_property(WebsiteCard, 'card_type', readonly=True) +resource_property(WebsiteCard, 'card_uri', readonly=True) resource_property(WebsiteCard, 'created_at', readonly=True, transform=TRANSFORM.TIME) -resource_property(WebsiteCard, 'updated_at', readonly=True, transform=TRANSFORM.TIME) resource_property(WebsiteCard, 'deleted', readonly=True, transform=TRANSFORM.BOOL) +resource_property(WebsiteCard, 'preview_url', readonly=True) +resource_property(WebsiteCard, 'website_dest_url', readonly=True) +resource_property(WebsiteCard, 'website_display_url', readonly=True) +resource_property(WebsiteCard, 'website_title', readonly=True) +resource_property(WebsiteCard, 'updated_at', readonly=True, transform=TRANSFORM.TIME) # writable +resource_property(WebsiteCard, 'image_media_id') resource_property(WebsiteCard, 'name') resource_property(WebsiteCard, 'website_title') resource_property(WebsiteCard, 'website_url') -resource_property(WebsiteCard, 'website_cta') -resource_property(WebsiteCard, 'image_media_id') class VideoWebsiteCard(Resource, Persistence): @@ -190,8 +200,6 @@ class VideoWebsiteCard(Resource, Persistence): resource_property(VideoWebsiteCard, 'video_poster_width', readonly=True) resource_property(VideoWebsiteCard, 'video_url', readonly=True) resource_property(VideoWebsiteCard, 'video_width', readonly=True) -resource_property(VideoWebsiteCard, 'website_dest_url', readonly=True) -resource_property(VideoWebsiteCard, 'website_display_url', readonly=True) # writable resource_property(VideoWebsiteCard, 'name') resource_property(VideoWebsiteCard, 'title') @@ -210,7 +218,7 @@ class LeadGenCard(Resource, Persistence): # lead gen card properties # read-only resource_property(LeadGenCard, 'id', readonly=True) -resource_property(LeadGenCard, 'preview_url', readonly=True) +resource_property(LeadGenCard, 'card_uri', readonly=True) resource_property(LeadGenCard, 'created_at', readonly=True, transform=TRANSFORM.TIME) resource_property(LeadGenCard, 'updated_at', readonly=True, transform=TRANSFORM.TIME) resource_property(LeadGenCard, 'deleted', readonly=True, transform=TRANSFORM.BOOL) @@ -241,7 +249,7 @@ class AppDownloadCard(Resource, Persistence): # app download card properties # read-only resource_property(AppDownloadCard, 'id', readonly=True) -resource_property(AppDownloadCard, 'preview_url', readonly=True) +resource_property(AppDownloadCard, 'card_uri', readonly=True) resource_property(AppDownloadCard, 'created_at', readonly=True, transform=TRANSFORM.TIME) resource_property(AppDownloadCard, 'updated_at', readonly=True, transform=TRANSFORM.TIME) resource_property(AppDownloadCard, 'deleted', readonly=True, transform=TRANSFORM.BOOL) @@ -270,20 +278,25 @@ class ImageAppDownloadCard(Resource, Persistence): # image app download card properties # read-only resource_property(ImageAppDownloadCard, 'id', readonly=True) +resource_property(ImageAppDownloadCard, 'image_display_height', readonly=True) +resource_property(ImageAppDownloadCard, 'image_display_width', readonly=True) +resource_property(ImageAppDownloadCard, 'wide_app_image', readonly=True) +resource_property(ImageAppDownloadCard, 'card_uri', readonly=True) +resource_property(ImageAppDownloadCard, 'card_type', readonly=True) resource_property(ImageAppDownloadCard, 'preview_url', readonly=True) resource_property(ImageAppDownloadCard, 'created_at', readonly=True, transform=TRANSFORM.TIME) resource_property(ImageAppDownloadCard, 'updated_at', readonly=True, transform=TRANSFORM.TIME) resource_property(ImageAppDownloadCard, 'deleted', readonly=True, transform=TRANSFORM.BOOL) # writable -resource_property(ImageAppDownloadCard, 'name') resource_property(ImageAppDownloadCard, 'app_country_code') +resource_property(ImageAppDownloadCard, 'app_cta') resource_property(ImageAppDownloadCard, 'iphone_app_id') resource_property(ImageAppDownloadCard, 'iphone_deep_link') resource_property(ImageAppDownloadCard, 'ipad_app_id') resource_property(ImageAppDownloadCard, 'ipad_deep_link') resource_property(ImageAppDownloadCard, 'googleplay_app_id') resource_property(ImageAppDownloadCard, 'googleplay_deep_link') -resource_property(ImageAppDownloadCard, 'app_cta') +resource_property(ImageAppDownloadCard, 'name') resource_property(ImageAppDownloadCard, 'wide_app_image_media_id') @@ -298,23 +311,28 @@ class VideoAppDownloadCard(Resource, Persistence): # video app download card properties # read-only resource_property(VideoAppDownloadCard, 'id', readonly=True) -resource_property(VideoAppDownloadCard, 'preview_url', readonly=True) -resource_property(VideoAppDownloadCard, 'video_url', readonly=True) -resource_property(VideoAppDownloadCard, 'video_poster_url', readonly=True) +resource_property(VideoAppDownloadCard, 'card_uri', readonly=True) +resource_property(VideoAppDownloadCard, 'card_type', readonly=True) resource_property(VideoAppDownloadCard, 'created_at', readonly=True, transform=TRANSFORM.TIME) -resource_property(VideoAppDownloadCard, 'updated_at', readonly=True, transform=TRANSFORM.TIME) resource_property(VideoAppDownloadCard, 'deleted', readonly=True, transform=TRANSFORM.BOOL) +resource_property(VideoAppDownloadCard, 'preview_url', readonly=True) +resource_property(VideoAppDownloadCard, 'updated_at', readonly=True, transform=TRANSFORM.TIME) +resource_property(VideoAppDownloadCard, 'video_content_id', readonly=True) +resource_property(VideoAppDownloadCard, 'video_hls_url', readonly=True) +resource_property(VideoAppDownloadCard, 'video_owner_id', readonly=True) +resource_property(VideoAppDownloadCard, 'video_poster_url', readonly=True) +resource_property(VideoAppDownloadCard, 'video_url', readonly=True) # writable -resource_property(VideoAppDownloadCard, 'name') resource_property(VideoAppDownloadCard, 'app_country_code') -resource_property(VideoAppDownloadCard, 'iphone_app_id') -resource_property(VideoAppDownloadCard, 'iphone_deep_link') +resource_property(VideoAppDownloadCard, 'app_cta') +resource_property(VideoAppDownloadCard, 'image_media_id') resource_property(VideoAppDownloadCard, 'ipad_app_id') resource_property(VideoAppDownloadCard, 'ipad_deep_link') +resource_property(VideoAppDownloadCard, 'iphone_app_id') +resource_property(VideoAppDownloadCard, 'iphone_deep_link') resource_property(VideoAppDownloadCard, 'googleplay_app_id') resource_property(VideoAppDownloadCard, 'googleplay_deep_link') -resource_property(VideoAppDownloadCard, 'app_cta') -resource_property(VideoAppDownloadCard, 'image_media_id') +resource_property(VideoAppDownloadCard, 'name') resource_property(VideoAppDownloadCard, 'video_id') @@ -328,21 +346,29 @@ class ImageConversationCard(Resource, Persistence): # image conversation card properties # read-only +resource_property(ImageConversationCard, 'card_type', readonly=True) +resource_property(ImageConversationCard, 'card_uri', readonly=True) +resource_property(ImageConversationCard, 'created_at', readonly=True, transform=TRANSFORM.TIME) +resource_property(ImageConversationCard, 'deleted', readonly=True, transform=TRANSFORM.BOOL) resource_property(ImageConversationCard, 'id', readonly=True) +resource_property(ImageConversationCard, 'image', readonly=True) resource_property(ImageConversationCard, 'preview_url', readonly=True) -resource_property(ImageConversationCard, 'created_at', readonly=True, transform=TRANSFORM.TIME) resource_property(ImageConversationCard, 'updated_at', readonly=True, transform=TRANSFORM.TIME) -resource_property(ImageConversationCard, 'deleted', readonly=True, transform=TRANSFORM.BOOL) # writable -resource_property(ImageConversationCard, 'name') -resource_property(ImageConversationCard, 'title') +resource_property(ImageConversationCard, 'cover_image_id') +resource_property(ImageConversationCard, 'fouth_cta') +resource_property(ImageConversationCard, 'fouth_cta_tweet') +resource_property(ImageConversationCard, 'image_media_id') resource_property(ImageConversationCard, 'first_cta') resource_property(ImageConversationCard, 'first_cta_tweet') +resource_property(ImageConversationCard, 'name') resource_property(ImageConversationCard, 'second_cta') resource_property(ImageConversationCard, 'second_cta_tweet') resource_property(ImageConversationCard, 'thank_you_text') resource_property(ImageConversationCard, 'thank_you_url') -resource_property(ImageConversationCard, 'image_media_id') +resource_property(ImageConversationCard, 'third_cta') +resource_property(ImageConversationCard, 'third_cta_tweet') +resource_property(ImageConversationCard, 'title') class VideoConversationCard(Resource, Persistence): @@ -355,24 +381,33 @@ class VideoConversationCard(Resource, Persistence): # video conversation card properties # read-only + +resource_property(VideoConversationCard, 'card_uri', readonly=True) +resource_property(VideoConversationCard, 'card_type', readonly=True) +resource_property(VideoConversationCard, 'created_at', readonly=True, transform=TRANSFORM.TIME) +resource_property(VideoConversationCard, 'deleted', readonly=True, transform=TRANSFORM.BOOL) resource_property(VideoConversationCard, 'id', readonly=True) resource_property(VideoConversationCard, 'preview_url', readonly=True) resource_property(VideoConversationCard, 'video_url', readonly=True) resource_property(VideoConversationCard, 'video_poster_url', readonly=True) -resource_property(VideoConversationCard, 'created_at', readonly=True, transform=TRANSFORM.TIME) resource_property(VideoConversationCard, 'updated_at', readonly=True, transform=TRANSFORM.TIME) -resource_property(VideoConversationCard, 'deleted', readonly=True, transform=TRANSFORM.BOOL) # writable -resource_property(VideoConversationCard, 'name') -resource_property(VideoConversationCard, 'title') -resource_property(VideoConversationCard, 'first_cta') -resource_property(VideoConversationCard, 'first_cta_tweet') -resource_property(VideoConversationCard, 'second_cta') -resource_property(VideoConversationCard, 'second_cta_tweet') -resource_property(VideoConversationCard, 'thank_you_text') -resource_property(VideoConversationCard, 'thank_you_url') -resource_property(VideoConversationCard, 'image_media_id') -resource_property(VideoConversationCard, 'video_id') +resource_property(ImageConversationCard, 'cover_image_id') +resource_property(ImageConversationCard, 'cover_video_id') +resource_property(ImageConversationCard, 'fouth_cta') +resource_property(ImageConversationCard, 'fouth_cta_tweet') +resource_property(ImageConversationCard, 'image_media_id') +resource_property(ImageConversationCard, 'first_cta') +resource_property(ImageConversationCard, 'first_cta_tweet') +resource_property(ImageConversationCard, 'name') +resource_property(ImageConversationCard, 'second_cta') +resource_property(ImageConversationCard, 'second_cta_tweet') +resource_property(ImageConversationCard, 'thank_you_text') +resource_property(ImageConversationCard, 'thank_you_url') +resource_property(ImageConversationCard, 'third_cta') +resource_property(ImageConversationCard, 'third_cta_tweet') +resource_property(ImageConversationCard, 'title') +resource_property(ImageConversationCard, 'video_id') class ScheduledTweet(Resource, Persistence): From b8f22d4ed15128db097a2a1d010dc4a6ae3ba482 Mon Sep 17 00:00:00 2001 From: carmenjyuen Date: Fri, 1 Dec 2017 12:38:38 -0800 Subject: [PATCH 2/5] Removed trailing spaces and alphabetized except for lead gen and app download cards --- twitter_ads/creative.py | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/twitter_ads/creative.py b/twitter_ads/creative.py index 7a98757..500fb3a 100644 --- a/twitter_ads/creative.py +++ b/twitter_ads/creative.py @@ -108,16 +108,16 @@ class AccountMedia(Resource, Persistence): # video properties # read-only +resource_property(AccountMedia, 'created_at', readonly=True, transform=TRANSFORM.TIME) +resource_property(AccountMedia, 'deleted', readonly=True, transform=TRANSFORM.BOOL) +resource_property(AccountMedia, 'duration', readonly=True) resource_property(AccountMedia, 'id', readonly=True) resource_property(AccountMedia, 'media_url', readonly=True) -resource_property(AccountMedia, 'duration', readonly=True) -resource_property(AccountMedia, 'created_at', readonly=True, transform=TRANSFORM.TIME) resource_property(AccountMedia, 'updated_at', readonly=True, transform=TRANSFORM.TIME) -resource_property(AccountMedia, 'deleted', readonly=True, transform=TRANSFORM.BOOL) # writable +resource_property(AccountMedia, 'creative_type') resource_property(AccountMedia, 'media_id') resource_property(AccountMedia, 'video_id') -resource_property(AccountMedia, 'creative_type') class MediaCreative(Resource, Persistence): @@ -153,13 +153,13 @@ class WebsiteCard(Resource, Persistence): # website card properties # read-only +resource_property(WebsiteCard, 'card_type', readonly=True) +resource_property(WebsiteCard, 'card_uri', readonly=True) +resource_property(WebsiteCard, 'created_at', readonly=True, transform=TRANSFORM.TIME) resource_property(WebsiteCard, 'id', readonly=True) resource_property(WebsiteCard, 'image', readonly=True) resource_property(WebsiteCard, 'image_display_height', readonly=True) resource_property(WebsiteCard, 'image_display_width', readonly=True) -resource_property(WebsiteCard, 'card_type', readonly=True) -resource_property(WebsiteCard, 'card_uri', readonly=True) -resource_property(WebsiteCard, 'created_at', readonly=True, transform=TRANSFORM.TIME) resource_property(WebsiteCard, 'deleted', readonly=True, transform=TRANSFORM.BOOL) resource_property(WebsiteCard, 'preview_url', readonly=True) resource_property(WebsiteCard, 'website_dest_url', readonly=True) @@ -217,9 +217,9 @@ class LeadGenCard(Resource, Persistence): # lead gen card properties # read-only -resource_property(LeadGenCard, 'id', readonly=True) resource_property(LeadGenCard, 'card_uri', readonly=True) resource_property(LeadGenCard, 'created_at', readonly=True, transform=TRANSFORM.TIME) +resource_property(LeadGenCard, 'id', readonly=True) resource_property(LeadGenCard, 'updated_at', readonly=True, transform=TRANSFORM.TIME) resource_property(LeadGenCard, 'deleted', readonly=True, transform=TRANSFORM.BOOL) # writable @@ -282,7 +282,7 @@ class ImageAppDownloadCard(Resource, Persistence): resource_property(ImageAppDownloadCard, 'image_display_width', readonly=True) resource_property(ImageAppDownloadCard, 'wide_app_image', readonly=True) resource_property(ImageAppDownloadCard, 'card_uri', readonly=True) -resource_property(ImageAppDownloadCard, 'card_type', readonly=True) +resource_property(ImageAppDownloadCard, 'card_type', readonly=True) resource_property(ImageAppDownloadCard, 'preview_url', readonly=True) resource_property(ImageAppDownloadCard, 'created_at', readonly=True, transform=TRANSFORM.TIME) resource_property(ImageAppDownloadCard, 'updated_at', readonly=True, transform=TRANSFORM.TIME) @@ -310,11 +310,11 @@ class VideoAppDownloadCard(Resource, Persistence): # video app download card properties # read-only -resource_property(VideoAppDownloadCard, 'id', readonly=True) resource_property(VideoAppDownloadCard, 'card_uri', readonly=True) resource_property(VideoAppDownloadCard, 'card_type', readonly=True) resource_property(VideoAppDownloadCard, 'created_at', readonly=True, transform=TRANSFORM.TIME) resource_property(VideoAppDownloadCard, 'deleted', readonly=True, transform=TRANSFORM.BOOL) +resource_property(VideoAppDownloadCard, 'id', readonly=True) resource_property(VideoAppDownloadCard, 'preview_url', readonly=True) resource_property(VideoAppDownloadCard, 'updated_at', readonly=True, transform=TRANSFORM.TIME) resource_property(VideoAppDownloadCard, 'video_content_id', readonly=True) @@ -367,7 +367,7 @@ class ImageConversationCard(Resource, Persistence): resource_property(ImageConversationCard, 'thank_you_text') resource_property(ImageConversationCard, 'thank_you_url') resource_property(ImageConversationCard, 'third_cta') -resource_property(ImageConversationCard, 'third_cta_tweet') +resource_property(ImageConversationCard, 'third_cta_tweet') resource_property(ImageConversationCard, 'title') @@ -405,7 +405,7 @@ class VideoConversationCard(Resource, Persistence): resource_property(ImageConversationCard, 'thank_you_text') resource_property(ImageConversationCard, 'thank_you_url') resource_property(ImageConversationCard, 'third_cta') -resource_property(ImageConversationCard, 'third_cta_tweet') +resource_property(ImageConversationCard, 'third_cta_tweet') resource_property(ImageConversationCard, 'title') resource_property(ImageConversationCard, 'video_id') From b6af7d3af9f00aa5f1be4cbf18a6eac4ce977c26 Mon Sep 17 00:00:00 2001 From: carmenjyuen Date: Tue, 5 Dec 2017 14:47:57 -0800 Subject: [PATCH 3/5] Made some changes from Juan's comments --- twitter_ads/creative.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/twitter_ads/creative.py b/twitter_ads/creative.py index 500fb3a..b8d0606 100644 --- a/twitter_ads/creative.py +++ b/twitter_ads/creative.py @@ -82,17 +82,17 @@ class Video(Resource, Persistence): resource_property(Video, 'aspect_ratio', readonly=True) resource_property(Video, 'created_at', readonly=True, transform=TRANSFORM.TIME) resource_property(Video, 'deleted', readonly=True, transform=TRANSFORM.BOOL) -resource_property(Video, 'description') -resource_property(Video, 'duration', readonly=True) +resource_property(Video, 'duration', readonly=True, transform=TRANSFORM.INT) resource_property(Video, 'id', readonly=True) resource_property(Video, 'media_key', readonly=True) resource_property(Video, 'poster_url', readonly=True) resource_property(Video, 'preview_url', readonly=True) resource_property(Video, 'ready_to_tweet', readonly=True, transform=TRANSFORM.BOOL) -resource_property(Video, 'reasons_not_servable', readonly=True) +resource_property(Video, 'reasons_not_servable', readonly=True, transform=TRANSFORM.LIST) resource_property(Video, 'tweeted', readonly=True, transform=TRANSFORM.BOOL) resource_property(Video, 'updated_at', readonly=True, transform=TRANSFORM.TIME) # writable +resource_property(Video, 'description') resource_property(Video, 'poster_image_media_id') resource_property(Video, 'title') resource_property(Video, 'video_media_id') @@ -106,11 +106,10 @@ class AccountMedia(Resource, Persistence): RESOURCE = '/' + API_VERSION + '/accounts/{account_id}/account_media/{id}' -# video properties +# Account Media properties # read-only resource_property(AccountMedia, 'created_at', readonly=True, transform=TRANSFORM.TIME) resource_property(AccountMedia, 'deleted', readonly=True, transform=TRANSFORM.BOOL) -resource_property(AccountMedia, 'duration', readonly=True) resource_property(AccountMedia, 'id', readonly=True) resource_property(AccountMedia, 'media_url', readonly=True) resource_property(AccountMedia, 'updated_at', readonly=True, transform=TRANSFORM.TIME) @@ -128,7 +127,7 @@ class MediaCreative(Resource, Persistence): RESOURCE = '/' + API_VERSION + '/accounts/{account_id}/media_creatives/{id}' -# video properties +# Media Creative properties # read-only resource_property(MediaCreative, 'approval_status', readonly=True) @@ -200,6 +199,8 @@ class VideoWebsiteCard(Resource, Persistence): resource_property(VideoWebsiteCard, 'video_poster_width', readonly=True) resource_property(VideoWebsiteCard, 'video_url', readonly=True) resource_property(VideoWebsiteCard, 'video_width', readonly=True) +resource_property(VideoWebsiteCard, 'website_dest_url', readonly=True) +resource_property(VideoWebsiteCard, 'website_display_url', readonly=True) # writable resource_property(VideoWebsiteCard, 'name') resource_property(VideoWebsiteCard, 'title') From ff93facb825ad2cffad893809e9f95704a625bf0 Mon Sep 17 00:00:00 2001 From: carmenjyuen Date: Tue, 5 Dec 2017 16:53:31 -0800 Subject: [PATCH 4/5] Changed Status to Text in campaign.py and examples --- examples/promoted_tweet.py | 2 +- examples/tweet_preview.py | 12 ++++++------ twitter_ads/campaign.py | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/examples/promoted_tweet.py b/examples/promoted_tweet.py index 4d97b69..16d8290 100644 --- a/examples/promoted_tweet.py +++ b/examples/promoted_tweet.py @@ -29,7 +29,7 @@ # create request for a nullcasted tweet with a website card website_card = WebsiteCard.all(account).next() -status = "Fine. There can be two. {card_url}".format(card_url=website_card.preview_url) +text = "Fine. There can be two. {card_url}".format(card_url=website_card.preview_url) tweet2 = Tweet.create(account, status) # promote the tweet using our line item diff --git a/examples/tweet_preview.py b/examples/tweet_preview.py index ba9a7f2..90417f4 100644 --- a/examples/tweet_preview.py +++ b/examples/tweet_preview.py @@ -22,17 +22,17 @@ Tweet.preview(account, id=661845592138776576) # preview a new tweet -Tweet.preview(account, status='Hello @AdsAPI!') -Tweet.preview(account, status='Hello @AdsAPI!', media_ids=[634458428836962305, 634458428836962306]) +Tweet.preview(account, text='Hello @AdsAPI!') +Tweet.preview(account, text='Hello @AdsAPI!', media_ids=[634458428836962305, 634458428836962306]) # preview a new tweet with an embedded card website_card = WebsiteCard.all(account).next() -Tweet.preview(account, status='Hello @AdsAPI!', card_id=website_card.id) +Tweet.preview(account, text='Hello @AdsAPI!', card_id=website_card.id) # create a new null-casted tweet -Tweet.create(account, status='Hello from Python @AdsAPI!') -Tweet.create(account, status='Hello @AdsAPI!', media_ids=[634458428836962305, 634458428836962306]) +Tweet.create(account, text='Hello from Python @AdsAPI!') +Tweet.create(account, text='Hello @AdsAPI!', media_ids=[634458428836962305, 634458428836962306]) # create a new null-casted tweet with an embedded card website_card = WebsiteCard.all(account).next() -Tweet.create(account, status='Hello @AdsAPI! {link}'.format(link=website_card.preview_url)) +Tweet.create(account, text='Hello @AdsAPI! {link}'.format(link=website_card.preview_url)) diff --git a/twitter_ads/campaign.py b/twitter_ads/campaign.py index add2c18..13565a3 100644 --- a/twitter_ads/campaign.py +++ b/twitter_ads/campaign.py @@ -259,11 +259,11 @@ def preview(klass, account, **kwargs): return response.body['data'] @classmethod - def create(klass, account, status, **kwargs): + def create(klass, account, **kwargs): """ Creates a "Promoted-Only" Tweet using the specialized Ads API end point. """ - params = {'status': status} + params = {} params.update(kwargs) # handles array to string conversion for media IDs From 075496552a7c6ab83a9244e7915a392673fda148 Mon Sep 17 00:00:00 2001 From: Juan Shishido Date: Thu, 7 Dec 2017 23:26:30 -0800 Subject: [PATCH 5/5] status to text --- examples/promoted_tweet.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/promoted_tweet.py b/examples/promoted_tweet.py index 16d8290..ec29806 100644 --- a/examples/promoted_tweet.py +++ b/examples/promoted_tweet.py @@ -19,7 +19,7 @@ line_item = account.line_items(None, campaign_ids=campaign.id).next() # create request for a simple nullcasted tweet -tweet1 = Tweet.create(account, 'There can be only one...') +tweet1 = Tweet.create(account, text='There can be only one...') # promote the tweet using our line item promoted_tweet = PromotedTweet(account) @@ -30,7 +30,7 @@ # create request for a nullcasted tweet with a website card website_card = WebsiteCard.all(account).next() text = "Fine. There can be two. {card_url}".format(card_url=website_card.preview_url) -tweet2 = Tweet.create(account, status) +tweet2 = Tweet.create(account, text) # promote the tweet using our line item promoted_tweet = PromotedTweet(account)