From a1ff4a0ddfc83e3a4bc2cf73efb051daa56daf0c Mon Sep 17 00:00:00 2001 From: System Administrator <@tellapart.com> Date: Mon, 11 Dec 2017 22:01:15 -0800 Subject: [PATCH 1/2] Remove leadgen & bug on website card --- twitter_ads/creative.py | 32 -------------------------------- 1 file changed, 32 deletions(-) diff --git a/twitter_ads/creative.py b/twitter_ads/creative.py index b8d0606..1c78f86 100644 --- a/twitter_ads/creative.py +++ b/twitter_ads/creative.py @@ -163,7 +163,6 @@ class WebsiteCard(Resource, Persistence): resource_property(WebsiteCard, 'preview_url', readonly=True) resource_property(WebsiteCard, 'website_dest_url', readonly=True) resource_property(WebsiteCard, 'website_display_url', readonly=True) -resource_property(WebsiteCard, 'website_title', readonly=True) resource_property(WebsiteCard, 'updated_at', readonly=True, transform=TRANSFORM.TIME) # writable resource_property(WebsiteCard, 'image_media_id') @@ -208,37 +207,6 @@ class VideoWebsiteCard(Resource, Persistence): resource_property(VideoWebsiteCard, 'website_url') -class LeadGenCard(Resource, Persistence): - - PROPERTIES = {} - - RESOURCE_COLLECTION = '/' + API_VERSION + '/accounts/{account_id}/cards/lead_gen' - RESOURCE = '/' + API_VERSION + '/accounts/{account_id}/cards/lead_gen/{id}' - - -# lead gen card properties -# read-only -resource_property(LeadGenCard, 'card_uri', readonly=True) -resource_property(LeadGenCard, 'created_at', readonly=True, transform=TRANSFORM.TIME) -resource_property(LeadGenCard, 'id', readonly=True) -resource_property(LeadGenCard, 'updated_at', readonly=True, transform=TRANSFORM.TIME) -resource_property(LeadGenCard, 'deleted', readonly=True, transform=TRANSFORM.BOOL) -# writable -resource_property(LeadGenCard, 'name') -resource_property(LeadGenCard, 'image_media_id') -resource_property(LeadGenCard, 'cta') -resource_property(LeadGenCard, 'fallback_url') -resource_property(LeadGenCard, 'privacy_policy_url') -resource_property(LeadGenCard, 'title') -resource_property(LeadGenCard, 'submit_url') -resource_property(LeadGenCard, 'submit_method') -resource_property(LeadGenCard, 'custom_destination_url') -resource_property(LeadGenCard, 'custom_destination_text') -resource_property(LeadGenCard, 'custom_key_screen_name') -resource_property(LeadGenCard, 'custom_key_name') -resource_property(LeadGenCard, 'custom_key_email') - - class AppDownloadCard(Resource, Persistence): PROPERTIES = {} From 646072a1ceb6f7bf3ca1c42de7eb44c6a757f561 Mon Sep 17 00:00:00 2001 From: bheddens Date: Mon, 11 Dec 2017 22:25:27 -0800 Subject: [PATCH 2/2] Update creative.py --- twitter_ads/creative.py | 29 ----------------------------- 1 file changed, 29 deletions(-) diff --git a/twitter_ads/creative.py b/twitter_ads/creative.py index 1c78f86..363447d 100644 --- a/twitter_ads/creative.py +++ b/twitter_ads/creative.py @@ -207,35 +207,6 @@ class VideoWebsiteCard(Resource, Persistence): resource_property(VideoWebsiteCard, 'website_url') -class AppDownloadCard(Resource, Persistence): - - PROPERTIES = {} - - RESOURCE_COLLECTION = '/' + API_VERSION + '/accounts/{account_id}/cards/app_download' - RESOURCE = '/' + API_VERSION + '/accounts/{account_id}/cards/app_download/{id}' - - -# app download card properties -# read-only -resource_property(AppDownloadCard, 'id', readonly=True) -resource_property(AppDownloadCard, 'card_uri', readonly=True) -resource_property(AppDownloadCard, 'created_at', readonly=True, transform=TRANSFORM.TIME) -resource_property(AppDownloadCard, 'updated_at', readonly=True, transform=TRANSFORM.TIME) -resource_property(AppDownloadCard, 'deleted', readonly=True, transform=TRANSFORM.BOOL) -# writable -resource_property(AppDownloadCard, 'name') -resource_property(AppDownloadCard, 'app_country_code') -resource_property(AppDownloadCard, 'iphone_app_id') -resource_property(AppDownloadCard, 'iphone_deep_link') -resource_property(AppDownloadCard, 'ipad_app_id') -resource_property(AppDownloadCard, 'ipad_deep_link') -resource_property(AppDownloadCard, 'googleplay_app_id') -resource_property(AppDownloadCard, 'googleplay_deep_link') -resource_property(AppDownloadCard, 'app_cta') -resource_property(AppDownloadCard, 'custom_icon_media_id') -resource_property(AppDownloadCard, 'custom_app_description') - - class ImageAppDownloadCard(Resource, Persistence): PROPERTIES = {}