use hashing function exposed by browserify #31

Merged
merged 1 commit into from Apr 5, 2014

Conversation

Projects
None yet
3 participants
@voidlock
Contributor

voidlock commented Mar 3, 2014

As of version 3.31.5 browserify uses relative paths to compute the file
hash. This means the karma-browserify bundle is incorrectly
hashing file ids to be required by the tests.

The hashing function is now available directly on the browserify bundle
instance (see browserify/browserify@9499ffb). This commit fixes the
above mentioned issue by delegating the file id hashing to this exposed
function.

At the moment though, that hashing function is prefixed with an _
possibly indicating that it's intended for private internal usage. So
any changes to this methods name or placement will break this code. In
that case though, the break will be much easier to detect than the
errors caused previously.

use hashing function exposed by browserify
As of version 3.31.5 browserify uses relative paths to compute the file
hash. This means the karma-browserify bundle is incorrectly
hashing file ids to be required by the tests.

The hashing function is now available directly on the browserify bundle
instance (see browserify/browserify@9499ffb). This commit fixes the
above mentioned issue by delegating the file id hashing to this exposed
function.

At the moment though, that hashing function is prefixed with an `_`
possibly indicating that it's intended for private internal usage. So
any changes to this methods name or placement will break this code. In
that case though, the break will be much easier to detect than the
errors caused previously.
@klipstein

This comment has been minimized.

Show comment Hide comment
@klipstein

klipstein Mar 14, 2014

@voidlock just stumbled upon this issue too and it was version 3.30.5 (just a minor correction) and this commit browserify/browserify@7abcc7d) which breaks karma-browserify with the latest browserify version. Using your branch fixed it in my environment.

@voidlock just stumbled upon this issue too and it was version 3.30.5 (just a minor correction) and this commit browserify/browserify@7abcc7d) which breaks karma-browserify with the latest browserify version. Using your branch fixed it in my environment.

dasmoth added a commit to dasmoth/dalliance that referenced this pull request Mar 23, 2014

alexgorbatchev added a commit that referenced this pull request Apr 5, 2014

Merge pull request #31 from voidlock/use-browserify-hash-function
Use hashing function exposed by browserify.

@alexgorbatchev alexgorbatchev merged commit ac4f4fa into xdissent:master Apr 5, 2014

@alexgorbatchev

This comment has been minimized.

Show comment Hide comment
@alexgorbatchev

alexgorbatchev Apr 5, 2014

Collaborator

Thanks for the PR!

Collaborator

alexgorbatchev commented Apr 5, 2014

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment