Replace breadcrumb.rb with what Techbang uses. #35

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant

Improvements:

  • ActiveSupport::Concern aware
  • Escaping any input from application (XSS-safe)
  • Lighter HTML.

This contribution is authorized from my boss.

Update:

API Changes:

  1. Please note that drop_page_title is removed from the library because it uses an instance variable @page_title which is from outside the library itself. Apps that called this method should instead explicitly call drop_breadcrumb @page_title in app layer.
  2. drop_breadcrumb now requires at least 1 argument, text, which was allowed to be nil in the previous implementation. Apps that invoked this method without any arguments should instead explicitly call drop_breadcrumb @page_title in app layer.
Replace breadcrumb.rb with what Techbang uses.
Improvements:

- ActiveSupport::Concern aware
- Escaping any input from application (XSS-safe)
- Lighter HTML.

This contribution is licensed from my boss.

There are some API changes on drop_breadcrumb and set_page_title drop_page_title (deprecated), please read the updates in the original PR notes.

@chitsaou chitsaou closed this Sep 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment