From 8042e0a0a3165042f114f5b689f053d997623572 Mon Sep 17 00:00:00 2001 From: Revix-0 <30447649+revix-0@users.noreply.github.com> Date: Mon, 20 Jun 2022 09:57:38 +0200 Subject: [PATCH] Add array in misc.hh to avoid double translation --- ui/xui/main-menu.cc | 2 +- ui/xui/misc.hh | 2 ++ ui/xui/popup-menu.cc | 14 ++------------ 3 files changed, 5 insertions(+), 13 deletions(-) diff --git a/ui/xui/main-menu.cc b/ui/xui/main-menu.cc index 6b43bd415b4..7df7bcb451b 100644 --- a/ui/xui/main-menu.cc +++ b/ui/xui/main-menu.cc @@ -823,7 +823,7 @@ void MainMenuAboutView::Draw() char *content = g_strdup_printf("%sScaling: %dx\nResolution: %dx%d\nDisplay Mode: %s", sys_info_text, nv2a_get_surface_scale_factor(), - width, height, GetDisplayMode()); + width, height, display_modes[g_config.display.ui.fit]); static uint32_t time_start = 0; if (ImGui::IsWindowAppearing()) { diff --git a/ui/xui/misc.hh b/ui/xui/misc.hh index b2c8a9e99df..3df21c5ad48 100644 --- a/ui/xui/misc.hh +++ b/ui/xui/misc.hh @@ -28,6 +28,8 @@ extern "C" { #include } +extern const char **display_modes; + static inline bool IsNavInputPressed(ImGuiNavInput i) { ImGuiIO &io = ImGui::GetIO(); diff --git a/ui/xui/popup-menu.cc b/ui/xui/popup-menu.cc index 204f5e84665..7d284ad2788 100644 --- a/ui/xui/popup-menu.cc +++ b/ui/xui/popup-menu.cc @@ -252,23 +252,13 @@ bool PopupMenu::DrawItems(PopupMenuItemDelegate &nav) class DisplayModePopupMenu : public virtual PopupMenu { public: - const char *GetDisplayMode() - { - const char *values[] = { - "Center", "Scale", "Scale (Widescreen 16:9)", "Scale (4:3)", "Stretch" - }; - return values[g_config.display.ui.fit]; - } + bool DrawItems(PopupMenuItemDelegate &nav) override { - const char *values[] = { - "Center", "Scale", "Scale (Widescreen 16:9)", "Scale (4:3)", "Stretch" - }; - for (int i = 0; i < CONFIG_DISPLAY_UI_FIT__COUNT; i++) { bool selected = g_config.display.ui.fit == i; if (m_focus && selected) ImGui::SetKeyboardFocusHere(); - if (PopupMenuCheck(values[i], "", selected)) + if (PopupMenuCheck(display_modes[i], "", selected)) g_config.display.ui.fit = i; }