New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alfresco 6.0 support #196

Open
wants to merge 16 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@kerkhofsd
Copy link
Contributor

kerkhofsd commented Oct 18, 2018

Description

This PR adds build artifacts for and integration tests against Alfresco 6.0

How Has This Been Tested?

Both 5 and 6 artifacts have been manually tested. Include integration tests for Dynamic Extensions on Alfresco 6.0 community.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the changelog.

script:
- ./gradlew build test
- ./gradlew check
- ./gradlew integrationTest -i --stacktrace

This comment has been minimized.

@vierbergenlars

vierbergenlars Oct 18, 2018

Member

You can add integrationTest to the check task

exceptionFormat = 'full'
}
}

This comment has been minimized.

@vierbergenlars

vierbergenlars Oct 18, 2018

Member
Suggested change Beta
check.dependsOn integrationTest
// stopContainers = false

// expose alfresco/inflow on a random port, comment to use default port (8080)
environment.put 'COMPOSE_ALFRESCO_TCP_8080', '8080'

This comment has been minimized.

@vierbergenlars

vierbergenlars Oct 18, 2018

Member

Do not start your environment variables with COMPOSE_ or DOCKER_, as these prefixes are reserved for configuring docker-compose or the docker client.

-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=8000
"
ports:
- ${COMPOSE_ALFRESCO_TCP_8080:-8080:8080} # by default expose on :8080

This comment has been minimized.

@vierbergenlars

vierbergenlars Oct 18, 2018

Member

Shouldn't this be prefixed with $DOCKER_IP, so you can choose to bind to localhost or a specific IP?

Suggested change Beta
- ${COMPOSE_ALFRESCO_TCP_8080:-8080:8080} # by default expose on :8080
- $DOCKER_IP:${COMPOSE_ALFRESCO_TCP_8080:-8080:8080} # by default expose on :8080
@@ -0,0 +1,15 @@
ARG ALFRESCO_BASE_IMAGE

This comment has been minimized.

@vierbergenlars

vierbergenlars Oct 18, 2018

Member

This file is not used, because you are using the docker-alfresco gradle plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment