Skip to content
Permalink
Browse files

[Graphics] Vulkan: add support for R10G10B10A2_UNorm and R11G11B10_Float

  • Loading branch information
phr00t authored and xen2 committed Jul 26, 2019
1 parent 224035d commit 11059c059d54e2d201b657cd1ab3d2981aaf7c35
Showing with 8 additions and 1 deletion.
  1. +8 −1 sources/engine/Xenko.Graphics/Vulkan/VulkanConvertExtensions.cs
@@ -237,11 +237,18 @@ public static void ConvertPixelFormat(PixelFormat inputFormat, out Format format
format = Format.R8SInt;
pixelSize = 1;
break;

case PixelFormat.R10G10B10A2_UNorm:
format = Format.A2R10G10B10UNormPack32;

This comment has been minimized.

Copy link
@Kryptos-FR

Kryptos-FR Jul 26, 2019

Collaborator

I don't think that is correct: the order of color and alpha is different.

This comment has been minimized.

Copy link
@xen2

xen2 Jul 26, 2019

Member

Thanks, overlooked that when cherry-picking.
Reverting.

This comment has been minimized.

Copy link
@phr00t

phr00t Jul 26, 2019

Author Contributor

I noticed the alpha difference too, but it appeared to be the closest match. It did allow the ThirdPersonPlatformer to run and look fine including this as-is.

pixelSize = 4;
break;
case PixelFormat.R8G8B8A8_UNorm:
format = Format.R8G8B8A8UNorm;
pixelSize = 4;
break;
case PixelFormat.R11G11B10_Float:
format = Format.B10G11R11UFloatPack32;

This comment has been minimized.

Copy link
@Kryptos-FR

Kryptos-FR Jul 26, 2019

Collaborator

I don't think that is correct: the order of colors is different.

pixelSize = 4;
break;
case PixelFormat.R8G8B8A8_UInt:
format = Format.R8G8B8A8UInt;
pixelSize = 4;

0 comments on commit 11059c0

Please sign in to comment.
You can’t perform that action at this time.