Skip to content
Permalink
Browse files

[Build] AssemblyProcessor task need to change identity on each change…

… otherwise we can run into microsoft/msbuild#663 (comment)
  • Loading branch information
xen2 committed Oct 18, 2019
1 parent f5bc7a6 commit e2c2eb19fcd6c8f9a2d49945170966cb38a12642
@@ -3,7 +3,7 @@
<PropertyGroup>
<!-- Override XenkoBuildDirectory only now so that Xenko common projects still get build in obj without XenkoGraphicsApi -->
<XenkoAssemblyProcessorGlobal>true</XenkoAssemblyProcessorGlobal>
<XenkoAssemblyProcessorPath>$(XenkoPackageXenko)\deps\AssemblyProcessor\Xenko.Core.AssemblyProcessor.Packed.exe</XenkoAssemblyProcessorPath>
<XenkoAssemblyProcessorPath>$(XenkoPackageXenko)\deps\AssemblyProcessor\Xenko.Core.AssemblyProcessor.Packed2.exe</XenkoAssemblyProcessorPath>

<XenkoDependenciesDir Condition="'$(XenkoDependenciesDir)' == ''">$(XenkoPackageXenko)\deps\</XenkoDependenciesDir>
<XenkoDependenciesDir Condition="'$(XenkoDependenciesDir)' != '' and !HasTrailingSlash('$(XenkoDependenciesDir)')">$(XenkoDependenciesDir)\</XenkoDependenciesDir>
@@ -0,0 +1,2 @@
Please update identity as soon as AssemblyProcessor is recompiled.
This can be done by bumping version (i.e. currently ".Packed2.exe") doing a mass file replace.

This file was deleted.

This file was deleted.

Git LFS file not shown
Git LFS file not shown
@@ -80,6 +80,6 @@
<PropertyGroup>
<PostBuildEvent>xcopy /d /y $(TargetDir)*.* $(SolutionDir)..\deps\AssemblyProcessor
cd $(SolutionDir)..\deps\AssemblyProcessor
$(ILRepack) Xenko.Core.AssemblyProcessor.exe Mono.Cecil.dll Mono.Cecil.Mdb.dll Mono.Cecil.Pdb.dll Mono.Cecil.Rocks.dll Mono.Options.dll System.ValueTuple.dll /out:Xenko.Core.AssemblyProcessor.Packed.exe</PostBuildEvent>
$(ILRepack) Xenko.Core.AssemblyProcessor.exe Mono.Cecil.dll Mono.Cecil.Mdb.dll Mono.Cecil.Pdb.dll Mono.Cecil.Rocks.dll Mono.Options.dll System.ValueTuple.dll /out:Xenko.Core.AssemblyProcessor.Packed2.exe</PostBuildEvent>
</PropertyGroup>
</Project>
@@ -63,8 +63,8 @@
<PropertyGroup>
<!--By default, turn on assembly processor-->
<XenkoAssemblyProcessor Condition="'$(XenkoAssemblyProcessor)' == ''">true</XenkoAssemblyProcessor>
<XenkoAssemblyProcessorPath Condition="Exists('$(MSBuildThisFileDirectory)..\tools\AssemblyProcessor\Xenko.Core.AssemblyProcessor.Packed.exe')">$(MSBuildThisFileDirectory)..\tools\AssemblyProcessor\Xenko.Core.AssemblyProcessor.Packed.exe</XenkoAssemblyProcessorPath>
<XenkoAssemblyProcessorPath Condition="Exists('$(MSBuildThisFileDirectory)..\..\..\..\deps\AssemblyProcessor\Xenko.Core.AssemblyProcessor.Packed.exe')">$(MSBuildThisFileDirectory)..\..\..\..\deps\AssemblyProcessor\Xenko.Core.AssemblyProcessor.Packed.exe</XenkoAssemblyProcessorPath>
<XenkoAssemblyProcessorPath Condition="Exists('$(MSBuildThisFileDirectory)..\tools\AssemblyProcessor\Xenko.Core.AssemblyProcessor.Packed2.exe')">$(MSBuildThisFileDirectory)..\tools\AssemblyProcessor\Xenko.Core.AssemblyProcessor.Packed2.exe</XenkoAssemblyProcessorPath>
<XenkoAssemblyProcessorPath Condition="Exists('$(MSBuildThisFileDirectory)..\..\..\..\deps\AssemblyProcessor\Xenko.Core.AssemblyProcessor.Packed2.exe')">$(MSBuildThisFileDirectory)..\..\..\..\deps\AssemblyProcessor\Xenko.Core.AssemblyProcessor.Packed2.exe</XenkoAssemblyProcessorPath>
</PropertyGroup>
<UsingTask TaskName="AssemblyProcessorTask" AssemblyFile="$(XenkoAssemblyProcessorPath)" Condition=" '$(XenkoAssemblyProcessorPath)' != '' And '$(XenkoAssemblyProcessorDev)' != 'true' "/>
<Target Name="XenkoRunAssemblyProcessor" DependsOnTargets="ResolveAssemblyReferences">

0 comments on commit e2c2eb1

Please sign in to comment.
You can’t perform that action at this time.