Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in PhysicsEngineFlags #152

Closed
Kryptos-FR opened this issue Aug 26, 2018 · 2 comments
Closed

Typo in PhysicsEngineFlags #152

Kryptos-FR opened this issue Aug 26, 2018 · 2 comments

Comments

@Kryptos-FR
Copy link
Collaborator

@Kryptos-FR Kryptos-FR commented Aug 26, 2018

Good first issue
Issues reserved for newcomers. Consider taking it only if it's your first time working on a feature or a bug in Xenko.

PhysicsEngineFlags has a value spelled ContinuosCollisionDetection instead of ContinuousCollisionDetection.

Because that value is used in an asset (here PhysicsSettings which is serialized in GameSettingsAsset), there is a need to write an asset upgrader.

@xen2

This comment has been minimized.

Copy link
Member

@xen2 xen2 commented Aug 26, 2018

Wasn't there an attribute to rename stuff with Yaml serialization? (Might work only for properties, not sure about enum)

@Kryptos-FR

This comment has been minimized.

Copy link
Collaborator Author

@Kryptos-FR Kryptos-FR commented Aug 26, 2018

I think it only works for property/field. But that could be an area investigated with that issue.

@xen2 xen2 added the help wanted label Sep 6, 2018
This was referenced Dec 20, 2018
@triinutamm triinutamm mentioned this issue Mar 6, 2019
@xen2 xen2 closed this in 5bb43aa Jul 2, 2019
phr00t added a commit to phr00t/FocusEngine that referenced this issue Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.