Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding shader to game project throws exception #324

Closed
tebjan opened this issue Jan 14, 2019 · 4 comments
Closed

Adding shader to game project throws exception #324

tebjan opened this issue Jan 14, 2019 · 4 comments

Comments

@tebjan
Copy link
Contributor

@tebjan tebjan commented Jan 14, 2019

Release Type: Official Release/GitHub (please choose appropriate option)
official

Version: Version number and/or git branch
beta01-359

Platform(s): Does the problem occur on Windows, Android...?
shared

Describe the bug
adding an .xksl file to the project throws exception (Xenko.Core, Version=3.1.0.1 not found) and gives red file in project

To Reproduce
add empty or existing .xksl file to game project

Expected behavior
shader keys should be generated

Screenshots
image

Log and callstacks
ShaderKeyGenStackTrace.txt

Additional context
trying to build a re-usable xenko package, but also happens in new empty game project.

@Kryptos-FR

This comment has been minimized.

Copy link
Collaborator

@Kryptos-FR Kryptos-FR commented Jan 14, 2019

Looks like it is missing the tool option to generate the corresponding .cs file.

@tebjan

This comment has been minimized.

Copy link
Contributor Author

@tebjan tebjan commented Jan 15, 2019

looking at the stack trace, the key gen tool seems to get called, but then doesn't find a specific reference:

at Xenko.Core.DataSerializers.Xenko_Core_ShadersSerializerFactory.Initialize()
at .cctor()
--- End of inner exception stack trace ---
at Xenko.VisualStudio.Commands.Shaders.ShaderKeyFileHelper.GenerateCode(String inputFileName, String inputFileContent)
@xen2

This comment has been minimized.

Copy link
Member

@xen2 xen2 commented Jan 15, 2019

I think I simply need to release a new VSPackage due to change to this line:
https://github.com/xenko3d/xenko/blob/master/sources/shared/Xenko.NuGetResolver/RestoreHelper.cs#L32
I will test if that fixes it.

Thanks for the report.

@tebjan

This comment has been minimized.

Copy link
Contributor Author

@tebjan tebjan commented Jan 19, 2019

another thing i noticed, we have a quite special nuget that brings many files into the .csproj via its content folder that also triggers the keygen tool. not sure how this should be defined. i can send you the nuget to test, if you are interested.
image

after close/re-open the solution the errors are gone, tho.

@xen2 xen2 closed this in 5c71597 Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.