Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative file path to resource incorrect in nuget #326

Closed
tebjan opened this issue Jan 18, 2019 · 4 comments
Closed

Relative file path to resource incorrect in nuget #326

tebjan opened this issue Jan 18, 2019 · 4 comments
Assignees
Milestone

Comments

@tebjan
Copy link
Contributor

@tebjan tebjan commented Jan 18, 2019

Release Type:
Official

Version:
beta01-359

Platform(s):
shared

Describe the bug
.xktex in assets contains incorrect relative path to resource file. the path is missing one "../" to get out of the 'Assets' folder and reach the 'Resources' folder.

To Reproduce

  1. add a texture to a xenko package in a sub folder of 'Assets' and build the nuget via 'Pack' command in visual studio
  2. add the produced nuget to a game project and inspect the assets of the package in game studio

Expected behavior
resource file should be found in installed nuget package

Screenshots
image
image

Log and callstacks

Additional context
trying to build a re-usable xenko package

@xen2

This comment has been minimized.

Copy link
Member

@xen2 xen2 commented Jan 18, 2019

Thanks for the report.
There is some logic to supposedly deal with fixing path but it's obviously wrong:

@xen2 xen2 added this to the 3.1 milestone Jan 18, 2019
@tebjan

This comment has been minimized.

Copy link
Contributor Author

@tebjan tebjan commented Jan 18, 2019

looks not too complicated to fix. is it possible to debug the PackAssets task? if so, is this the way to go? https://blogs.msdn.microsoft.com/msbuild/2005/09/28/how-to-debug-a-custom-msbuild-task-using-visual-studio/

@xen2

This comment has been minimized.

Copy link
Member

@xen2 xen2 commented Jan 19, 2019

@tebjan Yes, just debug the MSBuild.exe command with proper parameters, and put a breakpoint in PackAssets.cs

@xen2 xen2 self-assigned this Jan 19, 2019
@xen2 xen2 closed this in 5109915 Jan 19, 2019
@tebjan

This comment has been minimized.

Copy link
Contributor Author

@tebjan tebjan commented Jan 19, 2019

great, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.