Int3 as component property causes GS to crash

[boriscallens]

Release Type: Official Release

Version: 3.1.0.1-beta01-0441

Platform(s): Windows

Describe the bug
Adding a component property of the type Xenko.Core.Mathematics.Int3 causes Game Studio to crash with a confusing exception log upon attaching to any entity.

To Reproduce
Steps to reproduce the behavior:
Repro here: https://github.com/boriscallens/XenkoBuildRepro

1. Create a default game
2. Create a basic component
   [DataContract("MyComponent")]
   public class MyComponent: EntityComponent
   {
   // public Vector3 Working { get; set; }
   public Int3 Crashing { get; set; }
   }
3. Attach the component to any entity in the default scene in Game Studio

Expected behavior
The component is added to the entity and a Crashing property of the type int3 is editable on the component.
Alternatively/complementary a helpful error message and placeholder Unloadable component. Keeping GS functional for editing.
Alternatively a more helpful exception / stacktrace

Screenshots
N/A

Log and callstacks
buildLog.txt

Additional context
Maybe it has nothing to do with the type, but with the editor ui component?
That would explain the stacktrace pointing to XamlParseException: Add value to collection of type 'System.Windows.Controls.UIElementCollection' threw an exception.
From comparing the Int3 implementation with the Vector3 implementation I couldn't identify any relevant differences.

[Kryptos-FR]

The crash in Xaml UIElement probably means the template for the editor of Int3 has some issues.

If someone wants to investigate, the culprit could be in file https://github.com/xenko3d/xenko/blob/master/sources/presentation/Xenko.Core.Presentation/Themes/ExpressionDark/Theme.xaml#L4199 (at least that's a good starting point).

[dfkeenan]

Not sure if this is the problem but the Int<X>Editors don't override the default style key where as all the Vector<X>Editors do. i.e. https://github.com/xenko3d/xenko/blob/master/sources/presentation/Xenko.Core.Presentation/Controls/Vector3Editor.cs#L32

[Kryptos-FR]

To help investigate property grid issues, we have that test asset that can be used: https://github.com/xenko3d/xenko/blob/master/sources/editor/Xenko.Assets.Presentation/Test/TestAsset.cs

Note that it currently doesn't include IntX properties, which could be a good addition.

[dfkeenan]

There is an extra /> on line 4229 of that theme file.

xenko/sources/presentation/Xenko.Core.Presentation/Themes/ExpressionDark/Theme.xaml

Line 4229 in f56d4f8

WatermarkContentTemplate="{Binding WatermarkContentTemplate, RelativeSource={RelativeSource Mode=TemplatedParent}}"/> />

Deleting it fixes it.

[boriscallens]

Do fixes to Game Studio also get pushed through nuget somehow or is this a more involved process?