New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Theme #50

Closed
RUSshy opened this Issue Aug 5, 2018 · 16 comments

Comments

Projects
None yet
8 participants
@RUSshy

RUSshy commented Aug 5, 2018

Hi

The editor could get a little lift

There is just too many information, and too many colors, contrast is weird

Should go with a real dark / light theme, not something in the middle

Unity is about to get a new theme, the current one is already readable, but the new one is even better, it put the focus on the scene view, nothing busy, nothing fancy

ca2fb1b4-6250-498f-a873-9673f8eec2d6

17ca1803-e648-4a9f-acce-157fdaa34d55

@RUSshy

This comment has been minimized.

RUSshy commented Aug 5, 2018

I think i'll be able to contribute on this one

@Kryptos-FR

This comment has been minimized.

Collaborator

Kryptos-FR commented Aug 5, 2018

That's a good idea. We never took the time to properly cleanup the theme.

Most of the colors/styles/templates are defined in https://github.com/xenko3d/xenko/blob/master/sources/presentation/Xenko.Core.Presentation/Themes/ExpressionDark/Theme.xaml. There might be some other location where the colors are hardcoded, so that would be a good time to cleanup that and make sure everything is in the same theme.

Once that is done, the next step would be to provide a white/gray theme. Some people don't like dark themes (for example Michael from GameFromScratch). A high-contrast theme could also be a good idea.

@Kryptos-FR

This comment has been minimized.

Collaborator

Kryptos-FR commented Aug 5, 2018

Work can be done in parallel with #4 but might need some synchronization to make sure the images/icons fit with the new theme.

@qril

This comment has been minimized.

qril commented Aug 5, 2018

I don't think that xenko has a future with this clunky WPF thing. You should ditch it ASAP.
Why didn't you do something like unity did? Immediate gui proven to be quite a success.

@Hansolo128

This comment has been minimized.

Hansolo128 commented Aug 5, 2018

@qril that's just opinion. I like xenko's editor far more than unity's visually, even with it being rough around the edges. it's one of the reasons I wanted to try sticking with the engine. That and native .net implementation.

@Kryptos-FR

This comment has been minimized.

Collaborator

Kryptos-FR commented Aug 5, 2018

@qril if you work on a new UI that can support all the cases and scenario of the current editor, I'd be glad to review your merge request ;)

@0xaryan

This comment has been minimized.

Contributor

0xaryan commented Aug 6, 2018

@qril @RUSshy WPF is an awesome graphical system. There is nothing wrong with it (as you might know, Visual Studio and Visual Studio Blend are also written in WPF).
So, why not some inspirations from Dark Blend?

Project Selection

Project Selection

Consistent UI

Project Selection

Dark Xenko

Project Selection

@tzachshabtay

This comment has been minimized.

tzachshabtay commented Aug 6, 2018

WPF is an awesome graphical system. There is nothing wrong with it

There is one thing wrong with it: it's not cross platform.

@RUSshy

This comment has been minimized.

RUSshy commented Aug 6, 2018

I agree WPF is awesome and quite easy to customize, i'm only afraid about custom editor plugins, in unity it is really simple to create custom UI

@0xaryan

is your current progress available somewhere ? i'm also trying to clean the theme, maybe we should join force

@qril

This comment has been minimized.

qril commented Aug 6, 2018

It's not cross-platform. It's hard to maintain and extend. You need to host your game in another environment which make things more complicated. WPF (and all xaml based products in general) is complicated and over-engineered beast.
As far as I know all popular engine's editors (unity, godot, ue4) are implemented just as a game running by the engine itself. There is a rationale behind this. This will open a lot of new possibilities.

What we need is an editor as unified platform for content authoring tools and runtime components as assets/packages developed by community. Xenko developers should really focus on providing such platform first, not on implementing specific tools on top of old WPF editor.

@Kryptos-FR

This comment has been minimized.

Collaborator

Kryptos-FR commented Aug 6, 2018

@qril I don't think you realize how big a task it is to implement such UI. We are talking about months (years?) of development with no guarantee to reach the same level of functionalities that are currently available in the editor.

Until our community grows is a much higher number, I don't think it is worth to spend time on that.

It's not cross-platform.

So what? The market/target audience for games is mostly on Windows and mobiles. Xenko already supports building for Linux, Xamarin and MacOS could be supported. Even then, you would not make a game only for Linux or MacOS anyway but you would also target Windows. Therefore having the editing/build tools on Windows only is not such a big deal.

It's hard to maintain and extend.

Not necessarily. WPF has some limitations but it is not that hard to maintain, especially with its templating/style capabilities. But if you are talking on extending the editor itself, then WPF is not a limiting factor. We can make it work to allow plugins. In fact, although incomplete, its architecture is already plugin-based in some areas. And we could also look at pattern/libraries such as Prism.

Xenko developers should really focus on providing such platform first, not on implementing specific tools on top of old WPF editor.

  1. There is no such thing as "Xenko developers". We are a community now 😉. The only full-time developer at the moment is @xen2 and I would rather see him work on the engine and let the editor be improved by the community.
  2. As I said earlier, it is a huge task. I don't think we should allocate the whole community to making yet another editor. So opposite to you I think we should first focus on improving the existing user experience and add more tools and functionalities.

I'm not saying that if someone or a group of people wants to start to work on a new editor, they shouldn't. By all means, if you are motivated, go for it. But I don't think that it should be the main focus of the community.

All that said, you have the right to disagree with me.

@0xaryan

This comment has been minimized.

Contributor

0xaryan commented Aug 6, 2018

is your current progress available somewhere ? i'm also trying to clean the theme, maybe we should join force

@RUSshy Yes. I already made some changes in colors, menus, icons and some other items. They are now available in my fork of Xenko.

@Kryptos-FR

This comment has been minimized.

Collaborator

Kryptos-FR commented Aug 13, 2018

@Toriadus you should have a look at #83 as we are about to merge it. Any feedback welcome!

@Toriadus

This comment has been minimized.

Toriadus commented Aug 14, 2018

Tnx

xen2 added a commit that referenced this issue Aug 15, 2018

New dark theme and glyph icons #4 #50 (#83)
* Add windows chrome vector resources
* Add vector version of Xenko Logo
* Modify Xenko Geometry
* A forward step to Vector images
* Xaml simplify
* Blend UI first approach
* Fix merge mistake for Browse icon
* Add new set of drawing icons
* Change restore icon
* Add new set of glyph icons
* Fix DrawingImage syntax error
* Smaller menu icons
* Add vector icons
* Sharper edges
* Add support for HslColor
* Add Luminosity (Light/Dark) controller for a DrawingImage
* Replace ThemeController with brand new ThemedSourceExtension
* Separate logic from Markup
* Leave other drawings untouched
* Reform theme source extension
* Change color of an image
* Change color of Visual Studio logo
* Change color of Xenko Logo
* Replace AvalonDock png images with glyph ones
* Add Luminosity Check
* ImageExtension decolor feature
* Recolor vectors
* Add EventSetter for Image for color transformation that needs a code-behind
* Add docs
* [Presentation] Fix copyright notices.
* [Presentation] Fix formatting and code conventions.
- fix spacing
- one class per file
- remove unused using
- remove redundant this
- remove redundant cast

* Fix DefaultPropertyTemplateProviders image dynamic source
* Eye-friendly asset picker colors
* Change color of toolbar background
* TabItem lower left gap and higher MinWidth
* Fixed menu width for submenu
* DirectoryViewModel constructor refactor
* Correct margin for Property Grid's title icons
* Change design of scene tabs
* Change backcolor of menu group item container
* Visual Studio like dark blue statusbar in footer
* Fix globe icons luminosity
* Recolor and some other fixes to ComboBox, DockManager, DockManager Tabs and Scrollbar
* Change Operating Systems icons
@xen2

This comment has been minimized.

Member

xen2 commented Aug 15, 2018

@RUSshy @0xaryan OK to close this issue with #83 merge, or is there some additional work to do?

@0xaryan

This comment has been minimized.

Contributor

0xaryan commented Aug 15, 2018

@xen2 I think this can be closed, we can still open more detailed issues about themes in future.

@xen2 xen2 closed this Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment