Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted vs2019 version support from visual studio plugin installer #332

Closed
wants to merge 1 commit into from

Conversation

@tebjan
Copy link
Contributor

tebjan commented Jan 19, 2019

makes visual studio plugin installer work again

@tebjan tebjan changed the title reverted vs2019 version support from visual studio plugin installer Reverted vs2019 version support from visual studio plugin installer Jan 19, 2019
@tebjan

This comment has been minimized.

Copy link
Contributor Author

tebjan commented Jan 19, 2019

there might be a better fix in order to support all versions, this however works if someone needs it.

@Kryptos-FR

This comment has been minimized.

Copy link
Collaborator

Kryptos-FR commented Jan 20, 2019

@tebjan I don't have any issue with the plugin and VS 2017. Are you sure this revert is needed?

edit: nevermind, I saw the discussion on discord. I think we decided at some point to drop VS 2015 support, you might also need to update VS 2017 to the latest version.

@tebjan

This comment has been minimized.

Copy link
Contributor Author

tebjan commented Jan 20, 2019

still wondering why it would fail only because i have 2015 on my machine... that might need some investigation.

@xen2

This comment has been minimized.

Copy link
Member

xen2 commented Jan 20, 2019

Did you get the "install log"? (I could see there was one in the failure messagebox in your discord screenshot)

@tebjan

This comment has been minimized.

Copy link
Contributor Author

tebjan commented Jan 20, 2019

yes, here it is:
image
vs install log.txt

EDIT: there is even a second much shorter one after clicking close, but it seems this is related to uninstalling:
image

20.01.2019 17:46:29 - Microsoft VSIX Installer
20.01.2019 17:46:29 - -------------------------------------------
20.01.2019 17:46:30 - Initializing Uninstall...
20.01.2019 17:46:41 - Microsoft.VisualStudio.ExtensionManager.NotInstalledException: The extension with ID 'b0b8feb1-7b83-43fc-9fc0-70065ddb80a1' is not installed to any currently installed products.
   bei VSIXInstaller.App.InitializeUninstall()
   bei System.Threading.Tasks.Task.InnerInvoke()
   bei System.Threading.Tasks.Task.Execute()
@xen2

This comment has been minimized.

Copy link
Member

xen2 commented Jan 20, 2019

Thanks.
What version of Visual Studio 2017 do you have? Community or another one?

@xen2

This comment has been minimized.

Copy link
Member

xen2 commented Jan 20, 2019

Maybe you can show me the Visual Studio version selection screen you have with your custom vsix you made? (the one where you can choose which VS to install to)

@tebjan

This comment has been minimized.

Copy link
Contributor Author

tebjan commented Jan 20, 2019

image

this is current master including this PR:
image
sorry for the german...

@xen2

This comment has been minimized.

Copy link
Member

xen2 commented Jan 20, 2019

OK, last thing: when this failing vsix is running (through the launcher uninstall/install process), you should see a VSIXInstaller.exe process running. What's its path?
Also, what happens if you try to run the .vsix directly? (located in %UserProfile%\.nuget\packages\xenko.visualstudio.package\3.0.3\tools\)

@tebjan

This comment has been minimized.

Copy link
Contributor Author

tebjan commented Jan 20, 2019

this is the patch when running the compiled one:
"C:\Program Files (x86)\Microsoft Visual Studio\Installer\resources\app\ServiceHub\Services\Microsoft.VisualStudio.Setup.Service\VSIXInstaller.exe"

when running from xenko launcher i get:
"C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\VSIXInstaller.exe"

interestingly, my ".nuget\packages\xenko.visualstudio.package\3.0.3\tools" is empty...

@xen2

This comment has been minimized.

Copy link
Member

xen2 commented Jan 20, 2019

OK I think the fix is finding the proper VSIXInstaller.
Either use 15+ from now on, or use the global one from Microsoft.VisualStudio.Setup.Service just like when running vsix by hand.

@xen2

This comment has been minimized.

Copy link
Member

xen2 commented Jan 20, 2019

Thanks for the investigation.

@tebjan

This comment has been minimized.

Copy link
Contributor Author

tebjan commented Jan 20, 2019

yes, it also seems to run this one after the first error:
"C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VSIXInstaller.exe"

@tebjan

This comment has been minimized.

Copy link
Contributor Author

tebjan commented Jan 20, 2019

confirmed, when opening the vsix the launcher downloads with "C:\Program Files (x86)\Microsoft Visual Studio\Installer\resources\app\ServiceHub\Services\Microsoft.VisualStudio.Setup.Service\VSIXInstaller.exe" it asks for products and only shows 2017 with a checkbox.

@xen2

This comment has been minimized.

Copy link
Member

xen2 commented Jan 20, 2019

Does it also works with "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VSIXInstaller.exe"?

@tebjan

This comment has been minimized.

Copy link
Contributor Author

tebjan commented Jan 20, 2019

yes, that also works.

@xen2 xen2 closed this in 0743870 Jan 21, 2019
@xen2

This comment has been minimized.

Copy link
Member

xen2 commented Jan 21, 2019

Fixed in another patch, released 3.0.4.
Thanks for the help tracking this issue.

@tebjan tebjan deleted the vvvv:revert-vs2019-install-support branch Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.