Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/int3 editor #387

Merged
merged 2 commits into from Feb 19, 2019
Merged

Bugfix/int3 editor #387

merged 2 commits into from Feb 19, 2019

Conversation

@Kryptos-FR
Copy link
Collaborator

Kryptos-FR commented Feb 18, 2019

PR Details

Description

A syntax error in ExpressionDark\Theme.xaml caused an issue when attempting to use Int3 as the type of a serialized property on an asset.

This PR also add some properties to the TestAsset to ensure we can detect it sooner: instantiating this asset should never crash if everything works fine. Currently, with the changes but without the fix it does crash the Game Studio.

Related Issue

Fixes #383

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes (partially)
  • All new and existing tests passed.
@Kryptos-FR Kryptos-FR requested a review from xen2 Feb 18, 2019
@xen2 xen2 merged commit 5145134 into xenko3d:master Feb 19, 2019
2 checks passed
2 checks passed
WIP ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@xen2

This comment has been minimized.

Copy link
Member

xen2 commented Feb 19, 2019

Good catch, thanks!

@Kryptos-FR

This comment has been minimized.

Copy link
Collaborator Author

Kryptos-FR commented Feb 19, 2019

All credits to @boriscallens and @dfkeenan for identifying and help fixing the issue.

@xen2

This comment has been minimized.

Copy link
Member

xen2 commented Feb 19, 2019

Ha yes, just saw that when catching up on Discord!
Thanks guys!

phr00t added a commit to phr00t/FocusEngine that referenced this pull request Feb 19, 2019
[Presentation] Bugfix/int3 editor (xenko3d#387) (fixes xenko3d#383)
@Kryptos-FR Kryptos-FR deleted the Kryptos-FR:bugfix/Int3-editor branch Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.