Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets Compiler Support MSBuild Toolset Version 16.0 #421

Merged
merged 9 commits into from Mar 28, 2019

Conversation

@erictuvesson
Copy link
Contributor

erictuvesson commented Mar 24, 2019

PR Details

Added support for more MSBuild Toolset Versions.

Related Issue

#420

Motivation and Context

MSBuild Toolset Version 15.0 is not available anymore.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Mar 24, 2019

CLA assistant check
All committers have signed the CLA.

Copy link

wgraham17 left a comment

I’m relatively new to this project so be gentle 😊

...
@phr00t

This comment has been minimized.

Copy link
Contributor

phr00t commented Mar 27, 2019

Is this ready to be pulled in? If so, I may proactively pull it into my fork

@erictuvesson

This comment has been minimized.

Copy link
Contributor Author

erictuvesson commented Mar 27, 2019

I have tested it locally and it works for me. I installed VS2017 Build tools so the old also works for me, but I use this when I debug the asset compiler.

xen2 added 2 commits Mar 28, 2019
…his code will work with all newer versions of Visual Studio
@xen2

This comment has been minimized.

Copy link
Member

xen2 commented Mar 28, 2019

I have done some testing and ended up adding two commits. Should be OK to merge.

@xen2
xen2 approved these changes Mar 28, 2019
@xen2 xen2 merged commit 60b21cd into xenko3d:master Mar 28, 2019
2 checks passed
2 checks passed
WIP ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@xen2

This comment has been minimized.

Copy link
Member

xen2 commented Mar 28, 2019

Thanks @erictuvesson !

@erictuvesson erictuvesson deleted the erictuvesson:msbuild branch Mar 28, 2019
@myxibrium

This comment has been minimized.

Copy link

myxibrium commented Mar 28, 2019

Thanks a ton for fixing this! As this is blocking me from installing Xenko, I would like to know when this version is available via the Launcher, or if there's some other way I can install it. Thanks!

profan added a commit to profan/xenko that referenced this pull request May 3, 2019
…ixes xenko3d#420)

* Support MSBuild Toolset Version 16.0
* Switch to Microsoft.Build.Locator 1.1.2
* Use new "Current" ToolsVersion (microsoft/msbuild#3778) -- this code will work with all newer versions of Visual Studio
xen2 added a commit that referenced this pull request May 4, 2019
* Support MSBuild Toolset Version 16.0
* Switch to Microsoft.Build.Locator 1.1.2
* Use new "Current" ToolsVersion (microsoft/msbuild#3778) -- this code will work with all newer versions of Visual Studio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.